From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238AbbJZFJk (ORCPT ); Mon, 26 Oct 2015 01:09:40 -0400 Received: from down.free-electrons.com ([37.187.137.238]:38135 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750717AbbJZFJj (ORCPT ); Mon, 26 Oct 2015 01:09:39 -0400 Date: Mon, 26 Oct 2015 06:09:25 +0100 From: Thomas Petazzoni To: Marcin Wojtas Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Lior Amsalem , Andrew Lunn , Tawfik Bayouk , linux-kernel@vger.kernel.org, Nadav Haklai , Gregory Clement , "linux-arm-kernel@lists.infradead.org" , Sebastian Hesselbarth Subject: Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time Message-ID: <20151026060925.32ff2034@free-electrons.com> In-Reply-To: References: <1445347435-2333-1-git-send-email-thomas.petazzoni@free-electrons.com> <1445347435-2333-4-git-send-email-thomas.petazzoni@free-electrons.com> <20151026011036.2cb5b7a8@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marcin, On Mon, 26 Oct 2015 05:35:46 +0100, Marcin Wojtas wrote: > Thanks for the explanation - now it's clear. Good :-) Hopefully the explanation in PATCH 5/5 is also clear enough. > Btw, I checked the patches with mvneta in both 'standby' and 'mem' > modes on A38x (with not-yet-submitted support for PM in mvneta and > pinctrl) and everything works properly. Hence: Thanks for the testing. However, I wonder why you think those changes are need to get mvneta to work fine with the 'standby' mode ? While I do agree that they are need for the 'mem' mode, they shouldn't be needed for the 'standby' mode. For now, the standby mode only puts the CPU into deep-idle, and that's all: all devices remain powered on, and they don't lose their state. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com