From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753838AbbJZLpX (ORCPT ); Mon, 26 Oct 2015 07:45:23 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:55683 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753447AbbJZLpW (ORCPT ); Mon, 26 Oct 2015 07:45:22 -0400 Date: Mon, 26 Oct 2015 11:28:20 +0000 From: Charles Keepax To: Mark Brown CC: , , , , , , Subject: Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device tree binding document Message-ID: <20151026112820.GI10520@ck-lbox> References: <1444916828-8965-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1444916828-8965-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20151022124449.GH8232@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151022124449.GH8232@sirena.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-26_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1510260200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 22, 2015 at 01:44:49PM +0100, Mark Brown wrote: > On Thu, Oct 15, 2015 at 02:47:07PM +0100, Charles Keepax wrote: > > > +This document lists regulator specific bindings, see the primary binding > > +document: > > + ../mfd/arizona.txt > > + > > +Required properties: > > + > > + - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device, > > + as covered in regulator.txt > > + > > + - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102, > > + wm5110, wm8280, wm8998, wm1814) > > + > > + - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102, > > + wm5110, wm8280, wm8998, wm1814) > > + > > + - SPKVDD-supply : Speaker driver power supply (wm8997) > > + > > I'd expect these to be on the MFD since they're (with the exception of > AVDD which supplies the regulators IIRC) not part of the regulator > component of the device and are core for bringing it online. Yeah, fair enough I will move those back into the MFD part. > > > +Optional properties: > > + - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA > > + > > +Optional subnodes: > > + - ldo1 : Initial data for the LDO1 regulator, as covered in > > + Documentation/devicetree/bindings/regulator/regulator.txt > > + - micvdd : Initial data for the MICVDD regulator, as covered in > > + Documentation/devicetree/bindings/regulator/regulator.txt > > These are the properties for the regulator itself. > > > +++ b/MAINTAINERS > > @@ -11381,6 +11381,7 @@ W: http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices > > S: Supported > > F: Documentation/hwmon/wm83?? > > F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt > > +F: Documentation/devicetree/bindings/regulator/arizona-regulator.txt > > F: arch/arm/mach-s3c64xx/mach-crag6410* > > F: drivers/clk/clk-wm83*.c > > F: drivers/extcon/extcon-arizona.c > > I'd suggest moving this to a separate patch which adds all the new files > together to make it easier to merge things. Yeah no problem with making that a seperate patch. Thanks, Charles