From: Brian Foster <bfoster@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread
Date: Mon, 26 Oct 2015 10:08:47 -0400 [thread overview]
Message-ID: <20151026140847.GD59738@bfoster.bfoster> (raw)
In-Reply-To: <alpine.LNX.2.00.1510261552160.8998@pobox.suse.cz>
On Mon, Oct 26, 2015 at 03:53:40PM +0900, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> Since xfsaild has been converted to kthread in 0030807c, it calls
> try_to_freeze() during every AIL push iteration. It however doesn't set
> itself as freezable, and therefore this try_to_freeze() will never do
> anything.
>
> Before (hopefully eventually) kthread freezing gets converted to fileystem
> freezing, we'd rather mark xfsaild freezable (as it can generate I/O
> during suspend).
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
Looks fine to me:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_trans_ail.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 1098cf4..06d1a29 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -497,6 +497,7 @@ xfsaild(
> long tout = 0; /* milliseconds */
>
> current->flags |= PF_MEMALLOC;
> + set_freezable();
>
> while (!kthread_should_stop()) {
> if (tout && tout <= 20)
> --
> Jiri Kosina
> SUSE Labs
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-10-26 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 6:53 [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread Jiri Kosina
2015-10-26 14:08 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026140847.GD59738@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox