From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932558AbbJZOJQ (ORCPT ); Mon, 26 Oct 2015 10:09:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60905 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932476AbbJZOIt (ORCPT ); Mon, 26 Oct 2015 10:08:49 -0400 Date: Mon, 26 Oct 2015 10:08:47 -0400 From: Brian Foster To: Jiri Kosina Cc: Dave Chinner , Christoph Hellwig , linux-kernel@vger.kernel.org, xfs@oss.sgi.com Subject: Re: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread Message-ID: <20151026140847.GD59738@bfoster.bfoster> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2015 at 03:53:40PM +0900, Jiri Kosina wrote: > From: Jiri Kosina > > Since xfsaild has been converted to kthread in 0030807c, it calls > try_to_freeze() during every AIL push iteration. It however doesn't set > itself as freezable, and therefore this try_to_freeze() will never do > anything. > > Before (hopefully eventually) kthread freezing gets converted to fileystem > freezing, we'd rather mark xfsaild freezable (as it can generate I/O > during suspend). > > Signed-off-by: Jiri Kosina > --- Looks fine to me: Reviewed-by: Brian Foster > fs/xfs/xfs_trans_ail.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c > index 1098cf4..06d1a29 100644 > --- a/fs/xfs/xfs_trans_ail.c > +++ b/fs/xfs/xfs_trans_ail.c > @@ -497,6 +497,7 @@ xfsaild( > long tout = 0; /* milliseconds */ > > current->flags |= PF_MEMALLOC; > + set_freezable(); > > while (!kthread_should_stop()) { > if (tout && tout <= 20) > -- > Jiri Kosina > SUSE Labs > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs