From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752235AbbJZRR6 (ORCPT ); Mon, 26 Oct 2015 13:17:58 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:37028 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbbJZRR5 (ORCPT ); Mon, 26 Oct 2015 13:17:57 -0400 Date: Mon, 26 Oct 2015 18:17:50 +0100 From: Rabin Vincent To: Geert Uytterhoeven Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: Omit fixmap calls in text patching code if CONFIG_MMU=n Message-ID: <20151026171750.GA30888@debian> References: <1445846092-1979-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445846092-1979-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2015 at 08:54:52AM +0100, Geert Uytterhoeven wrote: > Protect the calls to set_fixmap() and clear_fixmap() by #ifdef > > CONFIG_MMU to fix this. > > Fixes: commit ab0615e2d6fb0747 ("arm: use fixmap for text patching when text is RO") > Signed-off-by: Geert Uytterhoeven Since both DEBUG_SET_MODULE_RONX and DEBUG_RODATA depend on MMU, we'll never get to this code on !MMU so this ifdef build fix should be ok. Acked-by: Rabin Vincent Thanks.