From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851AbbJZS07 (ORCPT ); Mon, 26 Oct 2015 14:26:59 -0400 Received: from mga14.intel.com ([192.55.52.115]:13795 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbbJZS06 (ORCPT ); Mon, 26 Oct 2015 14:26:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,201,1444719600"; d="scan'208";a="672116433" Date: Tue, 27 Oct 2015 02:26:11 +0800 From: kbuild test robot To: Bjorn Andersson Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Lee Jones , Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org Subject: [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings Message-ID: <20151026182611.GA14761@roam> References: <201510270209.ZSHdZKp5%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201510270209.ZSHdZKp5%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Bjorn Andersson Signed-off-by: Fengguang Wu --- pm8941-wled.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/video/backlight/pm8941-wled.c +++ b/drivers/video/backlight/pm8941-wled.c @@ -401,10 +401,7 @@ static int pm8941_wled_probe(struct plat bl = devm_backlight_device_register(&pdev->dev, wled->name, &pdev->dev, wled, &pm8941_wled_ops, &props); - if (IS_ERR(bl)) - return PTR_ERR(bl); - - return 0; + return PTR_ERR_OR_ZERO(bl); }; static const struct of_device_id pm8941_wled_match_table[] = {