From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932375AbbJ0NQW (ORCPT ); Tue, 27 Oct 2015 09:16:22 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38245 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932155AbbJ0NQU (ORCPT ); Tue, 27 Oct 2015 09:16:20 -0400 Date: Tue, 27 Oct 2015 06:32:55 -0700 (PDT) Message-Id: <20151027.063255.1140860748569110696.davem@davemloft.net> To: mst@redhat.com Cc: linux-kernel@vger.kernel.org, gkurz@linux.vnet.ibm.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH] vhost: fix performance on LE hosts From: David Miller In-Reply-To: <1445938640-32673-1-git-send-email-mst@redhat.com> References: <1445938640-32673-1-git-send-email-mst@redhat.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 27 Oct 2015 06:16:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Tue, 27 Oct 2015 11:37:39 +0200 > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > support for legacy devices") introduced a minor regression: even with > cross-endian disabled, and even on LE host, vhost_is_little_endian is > checking is_le flag so there's always a branch. > > To fix, simply check virtio_legacy_is_little_endian first. > > Cc: Greg Kurz > Signed-off-by: Michael S. Tsirkin Michael, do you want me to take this via the 'net' tree?