From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754423AbbJ0IjZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 Oct 2015 04:39:25 -0400
Received: from mail-wi0-f174.google.com ([209.85.212.174]:35323 "EHLO
	mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754383AbbJ0IjT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 Oct 2015 04:39:19 -0400
Date: Tue, 27 Oct 2015 08:39:15 +0000
From: Lee Jones <lee.jones@linaro.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>, kbuild-all@01.org,
        linux-kernel@vger.kernel.org, Jingoo Han <jingoohan1@gmail.com>,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings
Message-ID: <20151027083915.GR597@x1>
References: <201510270209.ZSHdZKp5%fengguang.wu@intel.com>
 <20151026182611.GA14761@roam>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20151026182611.GA14761@roam>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 27 Oct 2015, kbuild test robot wrote:

> drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> 
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  pm8941-wled.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks.

> --- a/drivers/video/backlight/pm8941-wled.c
> +++ b/drivers/video/backlight/pm8941-wled.c
> @@ -401,10 +401,7 @@ static int pm8941_wled_probe(struct plat
>  	bl = devm_backlight_device_register(&pdev->dev, wled->name,
>  					    &pdev->dev, wled,
>  					    &pm8941_wled_ops, &props);
> -	if (IS_ERR(bl))
> -		return PTR_ERR(bl);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(bl);
>  };
>  
>  static const struct of_device_id pm8941_wled_match_table[] = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog