From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753122AbbJ0KEh (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 Oct 2015 06:04:37 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:27441 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752161AbbJ0KEg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 Oct 2015 06:04:36 -0400
Date: Tue, 27 Oct 2015 13:04:07 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "J. German Rivera" <German.Rivera@freescale.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, bhamciu1@freescale.com,
        jiang.liu@linux.intel.com, bhupesh.sharma@freescale.com, agraf@suse.de,
        stuart.yoder@freescale.com, nir.erez@freescale.com,
        itai.katz@freescale.com, marc.zyngier@arm.com, scottwood@freescale.com,
        lijun.pan@freescale.com, leoli@freescale.com, R89243@freescale.com,
        richard.schmitt@freescale.com
Subject: Re: [PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error
 path
Message-ID: <20151027100407.GB7340@mwanda>
References: <1445874561-14761-1-git-send-email-German.Rivera@freescale.com>
 <1445874561-14761-9-git-send-email-German.Rivera@freescale.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1445874561-14761-9-git-send-email-German.Rivera@freescale.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 26, 2015 at 10:49:19AM -0500, J. German Rivera wrote:
> -error_cleanup_open:
> +dprc_scan_container_error:
>  	(void)dprc_close(mc_dev->mc_io, 0, mc_dev->mc_handle);

The error label was better in the original code.  A "goto
error_cleanup_open", that tells you what the goto does.  "goto
dprc_scan_container_error" tells you nothing because you can see from
the line before that there was a container error.  No new information.
It's just like a function name tells you what a function does.  You
wouldn't name the function called_from_main().

regards,
dan carpenter