From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754036AbbJ0LMN (ORCPT ); Tue, 27 Oct 2015 07:12:13 -0400 Received: from vm1.sequanux.org ([188.165.36.56]:36821 "EHLO vm1.sequanux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753510AbbJ0LMM (ORCPT ); Tue, 27 Oct 2015 07:12:12 -0400 Date: Tue, 27 Oct 2015 12:13:03 +0100 From: Simon Guinot To: Linus Walleij Cc: William Breathitt Gray , Andreas Bofjall , Diego Elio =?utf-8?Q?Petten=C3=B2?= , Mika Westerberg , Daniel Krueger , Bruno Randolf , Vivien Didelot , Alexandre Courbot , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16 Message-ID: <20151027111303.GD4665@kw.sim.vm.gnt> References: <20151019165914.GA22867@sophia> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PHCdUe6m4AxPMzOu" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PHCdUe6m4AxPMzOu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 27, 2015 at 11:06:58AM +0100, Linus Walleij wrote: > On Mon, Oct 19, 2015 at 6:59 PM, William Breathitt Gray > wrote: >=20 > > The ACCES 104-IDIO-16 family of PC/104 utility boards feature 16 > > optically isolated inputs and 16 optically isolated FET solid state > > outputs. This driver provides GPIO support for these 32 channels of > > digital I/O. Change-of-State detection interrupts are not supported. > > > > GPIO 0-15 correspond to digital outputs 0-15, while GPIO 16-31 > > correspond to digital inputs 0-15. The base port address for the device > > may be set via the idio_16_base module parameter. > > > > Signed-off-by: William Breathitt Gray > > --- > > Changes in v10: > > - Rename symbols to be more concise > > - Allocate GPIO device private data structure in probe function >=20 > Yes, exactly like this. :) >=20 > Patcha applied for kernel v4.4. >=20 > > +menu "ISA GPIO drivers" > > + > > +config GPIO_104_IDIO_16 > > + tristate "ACCES 104-IDIO-16 GPIO support" > > + depends on X86 > > + help > > + Enables GPIO support for the ACCES 104-IDIO-16 family. > > + > > +endmenu >=20 > I have five other drivers using port-based I/O: >=20 > gpio-f7188x.c > gpio-it87.c > gpio-sch.c > gpio-sch311x.c > gpio-ts5500.c >=20 > Do you think it makes sense to move all of these in under > the "ISA GPIO drivers" menu as well? I guess they all require > ISA after all. >=20 > (Added their maintainers to the To: line so I can get some input > on this.) Hi Linus, The Super-I/Os are connected to a LPC bridge. And since LPC is much like ISA for software, then I guess it makes sense to move the drivers gpio-f7188x and gpio-it87 under a "ISA GPIO drivers" menu. Simon --PHCdUe6m4AxPMzOu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYvXD8ACgkQgtp0PDeOcDqmYgCfWlnXfgewfLHSU2jIvHDn1Cwz pMEAoKGUsygoKQmy5+ZIvsU9eJ4p6XPX =VtxN -----END PGP SIGNATURE----- --PHCdUe6m4AxPMzOu--