From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965037AbbJ0Pwk (ORCPT ); Tue, 27 Oct 2015 11:52:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52534 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964996AbbJ0Pw2 (ORCPT ); Tue, 27 Oct 2015 11:52:28 -0400 Date: Tue, 27 Oct 2015 17:52:24 +0200 From: "Michael S. Tsirkin" To: David Miller Cc: linux-kernel@vger.kernel.org, gkurz@linux.vnet.ibm.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH] vhost: fix performance on LE hosts Message-ID: <20151027175057-mutt-send-email-mst@redhat.com> References: <1445938640-32673-1-git-send-email-mst@redhat.com> <20151027.063255.1140860748569110696.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151027.063255.1140860748569110696.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2015 at 06:32:55AM -0700, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Tue, 27 Oct 2015 11:37:39 +0200 > > > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > > support for legacy devices") introduced a minor regression: even with > > cross-endian disabled, and even on LE host, vhost_is_little_endian is > > checking is_le flag so there's always a branch. > > > > To fix, simply check virtio_legacy_is_little_endian first. > > > > Cc: Greg Kurz > > Signed-off-by: Michael S. Tsirkin > > Michael, do you want me to take this via the 'net' tree? Sure - especially since it looks like I have nothing else for this merge window (working on fixing shutdown races, but it's slow going). Thanks a lot! -- MST