From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965185AbbJ0S1K (ORCPT ); Tue, 27 Oct 2015 14:27:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:43585 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964840AbbJ0S1I (ORCPT ); Tue, 27 Oct 2015 14:27:08 -0400 Date: Tue, 27 Oct 2015 19:27:06 +0100 From: Maxime Ripard To: Adam Sampson Cc: lgirdwood@gmail.com, broonie@kernel.org, emilio@elopez.com.ar, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH] ASoC: sun4i-codec: use consistent names for PA controls Message-ID: <20151027182706.GE6114@lukather> References: <1445688712-31951-1-git-send-email-ats@offog.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IpbVkmxF4tDyP/Kb" Content-Disposition: inline In-Reply-To: <1445688712-31951-1-git-send-email-ats@offog.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IpbVkmxF4tDyP/Kb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Oct 24, 2015 at 01:11:52PM +0100, Adam Sampson wrote: > The power amplifier for the headphone output is called "the PA" and "the > headphone amplifier" in Allwinner's documentation for the A10 and A20. > sun4i-codec calls it "PA" in some places and "Pre-Amplifier" (which > isn't really accurate) in others, leading to user-visible controls with > different names referring to the same device. >=20 > When this driver implements audio input, it'll also need to expose > controls for the line and mic input preamps, so just referring to "the > Pre-Amplifier" will be ambiguous. >=20 > Change it to use "PA" consistently for the power amplifier. Just to avoid any ambiguity in the future, could you call that Power Amp(lifier?) instead? Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --IpbVkmxF4tDyP/Kb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWL8H6AAoJEBx+YmzsjxAgVCYP/2RQEKBTxDGZS+BnSb63hSem at44WVD+dKqxDHPVZLnGMHxSlyNN06uIK1ratT8UudizUb9FGPC3468tS1nh1nus pxaYCHRvIfRO+hv47N8l5Z1D7ymTjePUANZZ7kirbYYD9LRJp68Q9hZv2Zv2I8gK 09PhMJMdfNt1Zj3EJbpm3PNVdNeYum9dYy9nvPYgxyNLZXSpHIW8G3gCqoR/xFN+ p6O1km50YZ4kB+JBN+5bkNajnGNbUFx7OjQD+pZutUp16n/cyn7eIYq459g9ebt4 30wmChhTX9OE+mg5H4rvNKWpRtlyPlLY7dTPc/sLTgl6wMzSj6bPNlbiLRFNqLf7 I9QnvVsEbe8Aoiqr00Y40B5fPPUyx063WCdz4awUqppfXjo7i0T1OV95rvoYIh20 MTcD4Z24qtpvCBeZB7clEshQxzPvOYrIq4TKxt3orxDI4WiRTX9TZ9yG2lCgnvpC /cBKUhznJXgcvfMqEtInjMviXic9TGNMDRQlXNMlvMNn7pN79Sgnl8w/xz6nfZkJ yDzDMLXItmeX/D1i5LgzGLdPuN8Tb/Ewlcwxg+gr5TeXk+Tz9InqwsEbekhbbeav yWg2738ITL/XmZtuTGIU6myLN4sKAw1+PjeJrTdOpprt+OE1Doe2T2jRGg6g1ZZ/ 8FjFp9FoKZDhQqE3Y7+T =gdH5 -----END PGP SIGNATURE----- --IpbVkmxF4tDyP/Kb--