From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932429AbbJ1Bvw (ORCPT ); Tue, 27 Oct 2015 21:51:52 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:36517 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210AbbJ1Bvu (ORCPT ); Tue, 27 Oct 2015 21:51:50 -0400 Date: Tue, 27 Oct 2015 18:51:41 -0700 From: Dmitry Torokhov To: Michael Welling Cc: Tony Lindgren , Pavel Machek , Felipe Balbi , Sebastian Reichel , Roger Quadros , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v2] Input: tsc2005 - Add support for tsc2004 Message-ID: <20151028015141.GA11237@localhost> References: <201510280724.dKfeR76E%fengguang.wu@intel.com> <1445991421-29938-1-git-send-email-mwelling@ieee.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445991421-29938-1-git-send-email-mwelling@ieee.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On Tue, Oct 27, 2015 at 07:17:01PM -0500, Michael Welling wrote: > Adds support for the i2c based tsc2004. Support was added to the tsc2005 driver > due to the similarity of the devices. > > Signed-off-by: Michael Welling > --- > v2: Fixes Kconfig based on report for 0-day build bot. > > .../bindings/input/touchscreen/tsc2004.txt | 38 ++++ > drivers/input/touchscreen/Kconfig | 7 +- > drivers/input/touchscreen/tsc2005.c | 206 ++++++++++++++++----- Could we maybe split the code into core, spi and i2c drivers instead of keeping everything together and rely on #ifdefs? Thanks! -- Dmitry