From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755343AbbJ1Cmk (ORCPT ); Tue, 27 Oct 2015 22:42:40 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36136 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755215AbbJ1Cmh (ORCPT ); Tue, 27 Oct 2015 22:42:37 -0400 Date: Wed, 28 Oct 2015 08:12:33 +0530 From: Viresh Kumar To: Magnus Damm Cc: daniel.lezcano@linaro.org, laurent.pinchart+renesas@ideasonboard.com, geert+renesas@glider.be, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, chris.brandt@renesas.com, horms+renesas@verge.net.au, tglx@linutronix.de Subject: Re: [PATCH] clocksource: sh_mtu2: Fix multiple shutdown call issue Message-ID: <20151028024233.GC13324@ubuntu> References: <20151028014323.29894.70699.sendpatchset@little-apple> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151028014323.29894.70699.sendpatchset@little-apple> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28-10-15, 10:43, Magnus Damm wrote: > From: Magnus Damm > > On the r7s72100 Genmai board the MTU2 driver currently triggers a common > clock framework WARN_ON(enable_count) when disabling the clock due to > the MTU2 driver after recent callback rework may call ->set_state_shutdown() > multiple times. A similar issue was spotted for the TMU driver and fixed in: > 452b132 clocksource/drivers/sh_tmu: Fix traceback spotted in -next > > On r7s72100 Genmai v4.3-rc7 built with shmobile_defconfig spits out the > following during boot: > > sh_mtu2 fcff0000.timer: ch0: used for clock events > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:675 clk_core_disable+0x2c/0x6c() > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.3.0-rc7 #1 > Hardware name: Generic R7S72100 (Flattened Device Tree) > Backtrace: > [] (dump_backtrace) from [] (show_stack+0x18/0x1c) > r6:c0621fde r5:00000009 r4:00000000 r3:00200040 > [] (show_stack) from [] (dump_stack+0x74/0x90) > [] (dump_stack) from [] (warn_slowpath_common+0x88/0xb4) > r4:00000000 r3:00000000 > [] (warn_slowpath_common) from [] (warn_slowpath_null+0x24/0x2c) > r8:c78c0400 r7:c7ee8df8 r6:00000000 r5:600001d3 r4:c7806480 > [] (warn_slowpath_null) from [] (clk_core_disable+0x2c/0x6c) > [] (clk_core_disable) from [] (clk_disable+0x40/0x4c) > r4:c791be40 r3:00000000 > [] (clk_disable) from [] (sh_mtu2_disable+0x24/0x50) > r5:00000001 r4:c7963c00 > [] (sh_mtu2_disable) from [] (sh_mtu2_clock_event_shutdown+0x14/0x1c) > r4:c7963c40 r3:c0395d58 > [] (sh_mtu2_clock_event_shutdown) from [] (clockevents_switch_state+0xc8/0x114) > [] (clockevents_switch_state) from [] (clockevents_shutdown+0x18/0x28) > r5:c7963c40 r4:c7963c40 > [] (clockevents_shutdown) from [] (clockevents_exchange_device+0x70/0x78) > r4:00000000 r3:00000000 > [] (clockevents_exchange_device) from [] (tick_check_new_device+0x88/0xe0) > r5:00000000 r4:c7963c40 > [] (tick_check_new_device) from [] (clockevents_register_device+0xac/0x120) > r7:00000000 r6:a0000153 r5:c06ffe98 r4:c7963c40 > [] (clockevents_register_device) from [] (sh_mtu2_probe+0x230/0x350) > r6:00000000 r5:c7963c00 r4:c791b040 r3:c06ff134 > [] (sh_mtu2_probe) from [] (platform_drv_probe+0x50/0x98) > > Reported-by: Chris Brandt > Fixes: 19a9ffb ("clockevents/drivers/sh_mtu2: Migrate to new 'set-state' interface") > Cc: Viresh Kumar > Cc: Laurent Pinchart > Signed-off-by: Magnus Damm > --- > > drivers/clocksource/sh_mtu2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > --- 0001/drivers/clocksource/sh_mtu2.c > +++ work/drivers/clocksource/sh_mtu2.c 2015-10-27 16:20:07.350513000 +0900 > @@ -280,7 +280,9 @@ static int sh_mtu2_clock_event_shutdown( > { > struct sh_mtu2_channel *ch = ced_to_sh_mtu2(ced); > > - sh_mtu2_disable(ch); > + if (clockevent_state_periodic(ced)) > + sh_mtu2_disable(ch); > + > return 0; Thanks for doing this :) Reviewed-by: Viresh Kumar - -- viresh