From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965475AbbJ1JQi (ORCPT ); Wed, 28 Oct 2015 05:16:38 -0400 Received: from mail-by2on0111.outbound.protection.outlook.com ([207.46.100.111]:34514 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932124AbbJ1JQb (ORCPT ); Wed, 28 Oct 2015 05:16:31 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Date: Wed, 28 Oct 2015 17:14:54 +0800 From: Peter Chen To: Saurabh Sengar CC: , , Subject: Re: [PATCH] usb : replace dma_pool_alloc and memset with dma_pool_zalloc Message-ID: <20151028091446.GB10432@shlinux2> References: <1446016475-17100-1-git-send-email-saurabh.truth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1446016475-17100-1-git-send-email-saurabh.truth@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC013;1:yuxQZfsgHjMaT6H0k5FSeHSJIHw6mHfO79ZZUmtdiECDFxjlGcqillPRuqiHm7GtC9d6dmyKl3AB/yvtu0edCE3lhJ+pDQcFKuPUIzbUhFCUm2ymgTMaKt3Rua8cE3vj1wvxHQ2vID6DevHY1RXXmrUf7dAI463HD6ArXyVFoE7IsQsus0iHqIaZzzISN4/9Y0kLBE/d9JFeIza/HPTCmk2vMq2BatPxB2390Uk2+nRjO/Uv8+xsihNqn4wKP72W+gaSrBZrlA2M4qcNH6cb+4fC0DlIvA5eAUcsc5JrwPt+abQpc5YRPXbv2pHzvpNouzMxjjCdm6khLejISG5Cg+WrDJTw7JYzyZgLVJXi/UAVX9SIByLpmaKlS7v3KHP3 X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(24454002)(189002)(199003)(189998001)(110136002)(104016004)(6806005)(50466002)(87936001)(5001960100002)(86362001)(33656002)(92566002)(83506001)(11100500001)(47776003)(2950100001)(77096005)(33716001)(85426001)(23726002)(105606002)(106466001)(81156007)(97736004)(5007970100001)(54356999)(97756001)(50986999)(4001350100001)(5008740100001)(19580395003)(76176999)(19580405001)(46406003);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0301MB1267;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1267;2:ir9hdsr4/8kWEkdy5Em4hScK4X5tvoO0HvtnfbxZxhDZw1UqhjFvmaJn2cWKjxU0g/hWtY1c0vwMzZB6Zx5lSIC0xOwaRLmLUAoH9reDKUX/PDljSOyX3RLCB9wMiiK/B81kRRZn5H3NxbGHhPqMxLx9ja83YmQWVWTWZhP8fHg=;3:sJt8T8y2CVuyhJzCHh0qDoPkNZTOnpSpAzjEWLuiqBZhvA9y8teTP2NU2oT2L3afWZEfENV8PGJynC93wHYHt295kwuXy9gdq4A2Ac1DeuxJni2MDwJgjfTT8fK8YisDURHLIUjtYlCR8g6G9Z4+wfGfud37+X7TbhA2NqI4xn4xCkihYYCBhVyp8dgCpHhocdl++/RysFbqNbOh8jE2gJfkt9ICjdy+fDJ4GV9fiHY=;25:MJzGGQLDSPhCFThWA9GgQSmissg4b53qcb/HCKDb2lF9Wq4XIuFx3nYv9MDvqfiG/JQmWRxXGGYszgp8ok6TF8yjvZMKZ+r2TPXDpLZ3xKaMGus9Dx6Sigc2EkNB5G0O0tkHtRTIti56FRnhK0oJ29jp5sbIK7IJFn+0MKT4wHIuGzjQNlFY/xJZsOytQ2U/oG+Lg0g6hH5o/CVmmAhQsTwxwjMv898qVB2GLI2jCwTzopOvFwEpQ9rqYZoHC8rKZPVWErYEK0YyjG+NCRHcPA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1267; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1267;20:wQJaHmXHp8aoQLAlQ9yzbJ6x7d51ErmOm0bGBfOumweZF07hAMp+TJKei9MlXZ/+6GyUS2ic5FDaTeDHEMFoul4cbnJoXvX62IxkDzCsQ5HHndgLslqAsCxCp2tvC2pBVhoKp1lVmnXv1Ftz/pU8tvgx4dyy2MVUYO9gQBvGJpO7hr2mjlvWlzmvGJk+W4Midl52+3HOeO1snVkh4T3kf9XXzgDhOMlnhhaNen4gDBIx8InplmaFTZLAkC/LUb+0cZtbP0EWuW0nESEin5b8tXXSRySxah5RjxBZCRiVGmRkcrEaYXcE32sN/UYfIKvnagT7+7F9ntP7XAJJrDhyX1iF0cYA5Mlf8YvfogBPA7U=;4:ulmjmkmtHudPnvTFil6dyVMKBQF79DRKYRi4bGiEUZYjgZqpW9RcJdYi1mIXT5cPY3Hk7ZK5ZQO2p1+Mp1BFzP7ojwx11T0egyo1gO5SLikL2Ofhh+VzbcyruVgaUyWw7QtSI2B4Mk2NTRJMAb56IiJukbQkMh1KgpbLK2nT3WKO8jr7AS9qyjJgeAVfOBuXYvEHXjKAKyXSCLDtntBW1j+WjzTsFjXKlsNwgmjH3qs7SLnCE4JWGTAzsrsfoj9jQZ7ADEtBejqQiUx/yvV/2AoiRbPW0o6a1vSApBHwUtEIiLUPX2yjACoqTwpH21dUQu34AlSr1insjl0/mg6lGIHsostM0uFC1GU+vW1qc7xRe+nsMFAS8+mPa2KddANZwlyKe56kG7Ckhw2xAhECIA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046)(102215026);SRVR:BN3PR0301MB1267;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1267; X-Forefront-PRVS: 0743E8D0A6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR0301MB1267;23:FWiQizU17R17QsF4PVGLlsOQjDrFXopc7z4UY0D?= =?us-ascii?Q?4uOOE4t1QSU0KUNCna/K8B+r5J/tGfFSzy7PlLzvJTy1M0iA2mXRh4P0+rbr?= =?us-ascii?Q?t+pCnXEc/ZrLJpTqY3EMEEK+inaerGuOhZApoeC9m10wmi2sAWw6IcZytDxv?= =?us-ascii?Q?VQfpgfja+TY6b9UgaG9aK9/I0yY/mzVUzhf4mILsAAI9ZT+DEt6gJJZNk/Ru?= =?us-ascii?Q?QIUGDnaxwE/nCg1/ZAs6o8gbS9PRrQmroLvAn+HjhM5xb6vzEMHa439o1DV5?= =?us-ascii?Q?umprLrwJePslKDrIdd3Delb1ZM+JUwZTUzydqOpeZFb1ngiBpvQl+AtRKW32?= =?us-ascii?Q?X2L9o/QfKSsFjw8HCZfWQt63z/BfIiTYOkd1/0voZ+1SegMnn3TTr3wwFD6P?= =?us-ascii?Q?b0e8rTtSzDNqN7jcqQgnTV/eBr1wzaGAjmSCN7KKYZwI3DyAeRMsXcm6sS63?= =?us-ascii?Q?PcdOYRp+EexIADxUEbVeCefGOoEdlNRbXWG0+Q1W7IW8Ut7BsKqW7SxP3bOD?= =?us-ascii?Q?TBTcaol6Y3d7h6PzlXiRVGOul3+mA8uiKP85eCocuIMSV491YxZ06E0n2lnW?= =?us-ascii?Q?c+B13Tt7NtCYsLIHVF8TXdXIJXxkCUscOP5dFtWAMpxB5FbbczXc0mWTF4v3?= =?us-ascii?Q?2eHeGOmMz8ikanHPJ8uf10VF9ylKA6oKJLCb7X04pWL0d+AnWxswvl4/bQK4?= =?us-ascii?Q?QnZwJy2zU9ADa9pG3Sgm+o0YVYPuCzjnmcgEy7mny9Zv9diSnEWZvs/G+uvb?= =?us-ascii?Q?w2cqHIAVXi3T7EJH1kM02BY1nNi01SgeSp9HE2o7tbvPuddhAuAlITYhKkok?= =?us-ascii?Q?HWSVGfvjzUflnd4LLUDrOtWL1/KNM/bpkbi45nutZCaKt2b01w8DLU/WZIdf?= =?us-ascii?Q?91FqKB2uk6mO48yc0NGzwcqz7oaA8az7kSfCLhOy8EskNPhOMObDb7HBDjbd?= =?us-ascii?Q?mGclb498eQtn9KG9x7qiNjYRPBwAq8IajsJzdfWtJS0FeiQZKQWjszd2m+aE?= =?us-ascii?Q?YEdCaosouScg8mzXzayA36d/4aUJxJDt/6QwETmm3+5ADP3tw3S6e67YHejp?= =?us-ascii?Q?/x2GzOocqWh03J5qyy5ZAj8za91+J?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1267;5:TIwGznS6i9muOeuWar+JmSZu00cmezjQbKdo3Xg92gT/E+J5u1VmiPkIVjS+3svh/kG2+rsIICk3Y3m3qCbcMqxaew/L5sWacPYLIrDMTxHMalb4S8HqaMyKxZrsClrSLPOLy1MgKihoiUiY/vd3PA==;24:g/XOZ5a/J81AqC5/wMfFEVmzMhyG2AlxljUSOVBLTh4UhlUy2mQUOoHrx8ybiHcta9xM6IWE+Zp44i+yKWpIRKnv+Q4kD9EPfcYLAu9d8vw=;20:A3+NYbSO/CD8R0pVNQ7h3JyozVl4zsbCWNvoP5yd/Mkqm9SRgjacrqjcvRFcQKbyvRtJwbvSn9WQFVQ4SZkTpQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2015 09:16:28.0668 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB1267 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 12:44:35PM +0530, Saurabh Sengar wrote: > replace dma_pool_alloc and memset with a single call to dma_pool_zalloc > > Signed-off-by: Saurabh Sengar > --- > drivers/usb/chipidea/udc.c | 3 +-- > drivers/usb/gadget/udc/gr_udc.c | 3 +-- > drivers/usb/host/uhci-q.c | 3 +-- > drivers/usb/host/whci/qset.c | 3 +-- > drivers/usb/host/xhci-mem.c | 6 ++---- > 5 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > index 8223fe7..235b948f 100644 > --- a/drivers/usb/chipidea/udc.c > +++ b/drivers/usb/chipidea/udc.c > @@ -349,14 +349,13 @@ static int add_td_to_list(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq, > if (node == NULL) > return -ENOMEM; > > - node->ptr = dma_pool_alloc(hwep->td_pool, GFP_ATOMIC, > + node->ptr = dma_pool_zalloc(hwep->td_pool, GFP_ATOMIC, > &node->dma); > if (node->ptr == NULL) { > kfree(node); > return -ENOMEM; > } > > - memset(node->ptr, 0, sizeof(struct ci_hw_td)); > node->ptr->token = cpu_to_le32(length << __ffs(TD_TOTAL_BYTES)); > node->ptr->token &= cpu_to_le32(TD_TOTAL_BYTES); > node->ptr->token |= cpu_to_le32(TD_STATUS_ACTIVE); > diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c > index b9429bc..39b7136 100644 > --- a/drivers/usb/gadget/udc/gr_udc.c > +++ b/drivers/usb/gadget/udc/gr_udc.c > @@ -253,13 +253,12 @@ static struct gr_dma_desc *gr_alloc_dma_desc(struct gr_ep *ep, gfp_t gfp_flags) > dma_addr_t paddr; > struct gr_dma_desc *dma_desc; > > - dma_desc = dma_pool_alloc(ep->dev->desc_pool, gfp_flags, &paddr); > + dma_desc = dma_pool_zalloc(ep->dev->desc_pool, gfp_flags, &paddr); > if (!dma_desc) { > dev_err(ep->dev->dev, "Could not allocate from DMA pool\n"); > return NULL; > } > > - memset(dma_desc, 0, sizeof(*dma_desc)); > dma_desc->paddr = paddr; > > return dma_desc; > diff --git a/drivers/usb/host/uhci-q.c b/drivers/usb/host/uhci-q.c > index da6f56d..c17ea15 100644 > --- a/drivers/usb/host/uhci-q.c > +++ b/drivers/usb/host/uhci-q.c > @@ -248,11 +248,10 @@ static struct uhci_qh *uhci_alloc_qh(struct uhci_hcd *uhci, > dma_addr_t dma_handle; > struct uhci_qh *qh; > > - qh = dma_pool_alloc(uhci->qh_pool, GFP_ATOMIC, &dma_handle); > + qh = dma_pool_zalloc(uhci->qh_pool, GFP_ATOMIC, &dma_handle); > if (!qh) > return NULL; > > - memset(qh, 0, sizeof(*qh)); > qh->dma_handle = dma_handle; > > qh->element = UHCI_PTR_TERM(uhci); > diff --git a/drivers/usb/host/whci/qset.c b/drivers/usb/host/whci/qset.c > index dc31c42..3297473 100644 > --- a/drivers/usb/host/whci/qset.c > +++ b/drivers/usb/host/whci/qset.c > @@ -30,10 +30,9 @@ struct whc_qset *qset_alloc(struct whc *whc, gfp_t mem_flags) > struct whc_qset *qset; > dma_addr_t dma; > > - qset = dma_pool_alloc(whc->qset_pool, mem_flags, &dma); > + qset = dma_pool_zalloc(whc->qset_pool, mem_flags, &dma); > if (qset == NULL) > return NULL; > - memset(qset, 0, sizeof(struct whc_qset)); > > qset->qset_dma = dma; > qset->whc = whc; > diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c > index 41f841f..060c20c 100644 > --- a/drivers/usb/host/xhci-mem.c > +++ b/drivers/usb/host/xhci-mem.c > @@ -47,13 +47,12 @@ static struct xhci_segment *xhci_segment_alloc(struct xhci_hcd *xhci, > if (!seg) > return NULL; > > - seg->trbs = dma_pool_alloc(xhci->segment_pool, flags, &dma); > + seg->trbs = dma_pool_zalloc(xhci->segment_pool, flags, &dma); > if (!seg->trbs) { > kfree(seg); > return NULL; > } > > - memset(seg->trbs, 0, TRB_SEGMENT_SIZE); > /* If the cycle state is 0, set the cycle bit to 1 for all the TRBs */ > if (cycle_state == 0) { > for (i = 0; i < TRBS_PER_SEGMENT; i++) > @@ -517,12 +516,11 @@ static struct xhci_container_ctx *xhci_alloc_container_ctx(struct xhci_hcd *xhci > if (type == XHCI_CTX_TYPE_INPUT) > ctx->size += CTX_SIZE(xhci->hcc_params); > > - ctx->bytes = dma_pool_alloc(xhci->device_pool, flags, &ctx->dma); > + ctx->bytes = dma_pool_zalloc(xhci->device_pool, flags, &ctx->dma); > if (!ctx->bytes) { > kfree(ctx); > return NULL; > } > - memset(ctx->bytes, 0, ctx->size); > return ctx; > } > > -- For chipidea changes: Acked-by: Peter Chen -- Best Regards, Peter Chen