From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755723AbbJ1K0l (ORCPT ); Wed, 28 Oct 2015 06:26:41 -0400 Received: from exsmtp03.microchip.com ([198.175.253.49]:43459 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753273AbbJ1K0k (ORCPT ); Wed, 28 Oct 2015 06:26:40 -0400 X-Greylist: delayed 307 seconds by postgrey-1.27 at vger.kernel.org; Wed, 28 Oct 2015 06:26:39 EDT Date: Wed, 28 Oct 2015 11:21:09 +0100 From: Christian Gromm To: Muhammad Falak R Wani CC: Greg Kroah-Hartman , Andrey Shvetsov , Sudip Mukherjee , Masanari Iida , Adrian Remonda , , Subject: Re: [PATCH] staging: most: hdm-usb: Use setup_timer Message-ID: <20151028112109.161ff79a@muaddib> In-Reply-To: <1445652944-2811-1-git-send-email-falakreyaz@gmail.com> References: <1445652944-2811-1-git-send-email-falakreyaz@gmail.com> Organization: MCHP X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 24 Oct 2015 07:45:44 +0530 Muhammad Falak R Wani wrote: > Use the timer API function setup_timer instead of init_timer, removing > the structure field assignments. > > > > @timer@ > expression e1,e2,e3,fn_ptr; > @@ > -init_timer(&e1); > +setup_timer(&e1, fn_ptr, e2); > ... when != fn_ptr = e3 > -e1.function = fn_ptr; > -e1.data = e2; > > > > Signed-off-by: Muhammad Falak R Wani Acked-by: Christian Gromm > --- > drivers/staging/most/hdm-usb/hdm_usb.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c > index 0bf38c4..2e07313 100644 > --- a/drivers/staging/most/hdm-usb/hdm_usb.c > +++ b/drivers/staging/most/hdm-usb/hdm_usb.c > @@ -1235,11 +1235,10 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) > num_endpoints = usb_iface_desc->desc.bNumEndpoints; > mutex_init(&mdev->io_mutex); > INIT_WORK(&mdev->poll_work_obj, wq_netinfo); > - init_timer(&mdev->link_stat_timer); > + setup_timer(&mdev->link_stat_timer, link_stat_timer_handler, > + (unsigned long)mdev); > > mdev->usb_device = usb_dev; > - mdev->link_stat_timer.function = link_stat_timer_handler; > - mdev->link_stat_timer.data = (unsigned long)mdev; > mdev->link_stat_timer.expires = jiffies + (2 * HZ); > > mdev->iface.mod = hdm_usb_fops.owner;