From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755868AbbJ1Md0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 28 Oct 2015 08:33:26 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:51439 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751004AbbJ1MdZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 28 Oct 2015 08:33:25 -0400
Date: Wed, 28 Oct 2015 21:33:19 +0900
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
        Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/12] usb: serial: usb_debug: add support for dbc debug
 device
Message-ID: <20151028123319.GA6856@kroah.com>
References: <1446019243-5565-1-git-send-email-baolu.lu@linux.intel.com>
 <1446019243-5565-12-git-send-email-baolu.lu@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1446019243-5565-12-git-send-email-baolu.lu@linux.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 28, 2015 at 04:00:42PM +0800, Lu Baolu wrote:
> This patch add dbc debug device support in usb_debug driver.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  drivers/usb/serial/usb_debug.c | 29 ++++++++++++++++++++++++++---
>  1 file changed, 26 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/serial/usb_debug.c b/drivers/usb/serial/usb_debug.c
> index ca2fa5b..d4903b0 100644
> --- a/drivers/usb/serial/usb_debug.c
> +++ b/drivers/usb/serial/usb_debug.c
> @@ -32,7 +32,18 @@ static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(0x0525, 0x127a) },
>  	{ },
>  };
> -MODULE_DEVICE_TABLE(usb, id_table);
> +
> +static const struct usb_device_id dbc_id_table[] = {
> +	{ USB_DEVICE(0x1d6b, 0x0004) },
> +	{ },
> +};
> +
> +static const struct usb_device_id id_table_combined[] = {
> +	{ USB_DEVICE(0x0525, 0x127a) },
> +	{ USB_DEVICE(0x1d6b, 0x0004) },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(usb, id_table_combined);

You shouldn't need a "combined" module device table anymore, the module
core was changed a while ago to remove that restriction, you should be
able to just multiple exports of MODULE_DEVICE_TABLE and everything
should "just work" on the export side.  Now it might not work on the usb
core side, but that's a different issue...

thanks,

greg k-h