From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755469AbbJ1RWQ (ORCPT ); Wed, 28 Oct 2015 13:22:16 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:38903 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755177AbbJ1RWN (ORCPT ); Wed, 28 Oct 2015 13:22:13 -0400 Date: Wed, 28 Oct 2015 17:22:08 +0000 From: Lee Jones To: Joe Perches Cc: Krzysztof Kozlowski , Andrew Morton , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , k.kozlowski.k@gmail.com, wsa@the-dreams.de, linus.walleij@linaro.org, Sebastian Reichel , linux-kernel@vger.kernel.org, Chanwoo Choi , broonie@kernel.org, ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] get_maintainer: Add subsystem to reviewer output Message-ID: <20151028172208.GJ4058@x1> References: <1445971482.2757.27.camel@perches.com> <20151028082446.GF5828@x1> <56309419.4060908@samsung.com> <20151028093907.GP4931@pengutronix.de> <20151028095524.GP5828@x1> <5630CA06.7050503@samsung.com> <1446050506.2757.109.camel@perches.com> <20151028170116.GI4058@x1> <1446052121.2757.120.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1446052121.2757.120.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2015, Joe Perches wrote: > On Wed, 2015-10-28 at 17:01 +0000, Lee Jones wrote: > > On Wed, 28 Oct 2015, Joe Perches wrote: > > > > > Reviewer output currently does not include the subsystem > > > that matched. Add it. > > > > > > Miscellanea: > > > > > > o Add a get_subsystem_name routine to centralize this > > > > > > Signed-off-by: Joe Perches > > > --- > > > scripts/get_maintainer.pl | 31 ++++++++++++++++--------------- > > > 1 file changed, 16 insertions(+), 15 deletions(-) > > > > It looks like I'm going to have to drop the patch where we actually > > start using the R: tag properly due to some social, emotional issues. > > Not to mention logical. Hmm... we continue to disagree on that one. > > Despite that and not knowing Perl, I believe get_maintainer.pl should > > be printing out the subsystem next to 'reviewer' as it does for > > 'maintainer'. > > > > So with that in mind: > > Acked-by: Lee Jones > > It'd be better if you could add a "tested-by:" instead. Patch works as expected: Tested-by: Lee Jones Feel free to add my Suggested-by too, based on my belief that this patch was born out of this comment: "I'm sure we can make the output even more similar by listing the MAINTAINERS tag after "reviewer" too." -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog