From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756469AbbJ1Xrn (ORCPT ); Wed, 28 Oct 2015 19:47:43 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39812 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754826AbbJ1Xrl (ORCPT ); Wed, 28 Oct 2015 19:47:41 -0400 Date: Thu, 29 Oct 2015 08:47:15 +0900 From: Mark Brown To: Charles Keepax Cc: Robert Jarzmik , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Message-ID: <20151028234715.GG28319@sirena.org.uk> References: <1445983102-15490-1-git-send-email-robert.jarzmik@free.fr> <20151028124351.GK10520@ck-lbox> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yHmUJ2Jgby4Rx//r" Content-Disposition: inline In-Reply-To: <20151028124351.GK10520@ck-lbox> X-Cookie: "But I don't like Spam!!!!" User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 58.123.138.205 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yHmUJ2Jgby4Rx//r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 28, 2015 at 12:43:51PM +0000, Charles Keepax wrote: > On Tue, Oct 27, 2015 at 10:58:21PM +0100, Robert Jarzmik wrote: Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrolling through the irrelevant quoted material. > Why is the necessary? I can't see an obvious sign that these > writes bypass the cache in the non-regmap version, am I missing > something? Also if this is necessary I would quite like it to be > accompanied by a comment in the code to explain why it is safe to > do this here. Regarding the inherent dangers of cache bypass I > explained in my last email. It's probably worth pointing out that the functionality in the regmap API is essentially the same as the functionality in the old ASoC cache code, a conversion should pretty much be a case of directly translating API calls. --yHmUJ2Jgby4Rx//r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWMV6CAAoJECTWi3JdVIfQyJUH/RZEzqvI+AsFLiddYxAab9Bv 6QbFEAZgyM7W8jH34D2/FZ28n33t8jif3d56OtYLi7nEVIFzpEyIyT9WT7uvtqWH y10t5SF6zErVoggXDhCXxLK6OTuqQ2tTpIyq2ZvGtkunvs+KJlXGHETaSxuPrzdx BFOsGKdL4g03fEUCrWAZZoiQ/6MezB2Yxqr+pIa+rJY2SlAe4s0AQ/edaqLyIlUX QcaeWrVg3YIY0gEzDGVIqGIUj1lop60CdsPs7Jo2bx8aqcGA1zJ6FBkAlZzQ0+9x 2merXEDRlqvwzhEd/C50wDbCaRZYxzsJXc3LAtSAVcEYZ3Mv5CLjmv43Lv1WrjA= =lcar -----END PGP SIGNATURE----- --yHmUJ2Jgby4Rx//r--