From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752915AbbJ2IJt (ORCPT ); Thu, 29 Oct 2015 04:09:49 -0400 Received: from mail-bl2on0103.outbound.protection.outlook.com ([65.55.169.103]:6559 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750980AbbJ2IJi (ORCPT ); Thu, 29 Oct 2015 04:09:38 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; logfs.org; dkim=none (message not signed) header.d=none;logfs.org; dmarc=none action=none header.from=freescale.com; Date: Thu, 29 Oct 2015 16:07:56 +0800 From: Peter Chen To: Michal Marek CC: , , , Michal Marek , , Joern Engel , Prasad Joshi , Subject: Re: [PATCH 2/3] kbuild: Allow to specify composite modules with modname-m Message-ID: <20151029080745.GC8367@shlinux2> References: <1446038742-13482-1-git-send-email-mmarek@suse.cz> <1446038742-13482-2-git-send-email-mmarek@suse.cz> <20151029063427.GB8367@shlinux2> <5631D363.2010506@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5631D363.2010506@suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD022;1:W4/4tYK7WVrJVmgUzKopm9FKw26AUhNG4Yfu+3KKlv6u4CF+twtIje3Z4Qg06Af/VQmhE6R//VYsEeSJLoq1Xw1MyXZBFobqlVGHMlvVWzV26yngNuem9z1Q5GYzq8btQMV+7hz6dMcJHr8f49M3ZKFRq1Zk0vNDUnhN2b35Z+Y1yJoxLNhbcuxK39WF76fwwbnXRp34xbKygx94vuRRTJwR8GG1CmBoIDHYrTNymwuEZnhwRL7JhPZfzVmMN2FFbzuW+i+AMW9SGDv1RckVaKOfSxi2MMolhhUyY7MtPYvoFIkxDuOTeF7lhzfva0CJH5iwVvTwO8fwzowls11zwEjJd/VAtsgFVJ1FVHtE0JEl8z1KDFek8CRCohqGp9Sp X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(24454002)(19580405001)(77096005)(5007970100001)(19580395003)(105606002)(104016004)(5008740100001)(33656002)(46406003)(2950100001)(50466002)(189998001)(4001350100001)(110136002)(86362001)(92566002)(97756001)(93886004)(47776003)(33716001)(97736004)(5001960100002)(23726002)(76176999)(106466001)(83506001)(50986999)(54356999)(6806005)(81156007)(87936001)(85426001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB1273;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1273;2:gLINz9ZkMIbiyHoXuhH+lxBCOeN6ni/qVTVn6Sd0oOwQWMwNHlilmlxyVmqWzJuL0xIHX2ljI7gIqg352uH8Zvk0fHWmcWaQ2cQDWCB7M/+Mmle04MLOBtzCMyGAuS80eauJr1hbePnVH5Vy+DbkDYzGmNNO/6SiHWrC02ESxrE=;3:doR1LCUQa7eQxmGus75mH8HAMm6C/8wyxTm63ephscvxOqcSW1+05yc4KlyqvNVBQkJHFmaa5E7EyooooDtYZFupW+qk64tu6zvL4elxE7heFXysU747TZ91WEx53TfIObLNTOAYeLLxl3JHtnQKD73iqHrKHHd4MwYbXDQ25DQTzMHDFopXpR5XNiqFHsq7f/y5DMTKZAxE8cJP7A49M6oHcDQ1bmlgMEk/OhvmZsw=;25:mJcZaYpHRPNHYhqW42PwwOjTcEgMI3cImnEHeDa4q2vVsS6EjyY9HE7U+/RCF06T+yrv61ChDPGJlJ1iCiOtgzZb+NrrDvYAYTYQq4Ny0zxZ5/XDedEBMRul7ojjLK7WY3L+8oY8/marlV0HykweaqtnPWDFfSP4YpUO6Tl0lmTszB2rK58yjQbLqpJBC74oBdgWuxklnbYw17GQFdPAelv/638zkj+JLOGusYxwV1JfINDs5iDENXisdyMz8TkZ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1273; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1273;20:dMgBfUFS3kZUT3aoYmtOeMb7kMo8Qnx7Pyafjax9YW1lGd03+fXTOWs4o15gs7xcU7rYm76+KcF4erwP8kUhoeq+DbFhmqVLeaGxJJdZaz0qIFhielxNrtXwWwpNgPaealpZVn1ZIns8NFKDHTspqCzxytC+LtidTGuV9PHmynUz9IDCR1oIyPYNeOzkxuGR2EEbb3t94KkmpElRnkWXL9F5600PoMr6uBlTNV2hWH2iCB3UDHX+wShCiV7NhhQ22mS/M0UT8W225V7PF2aLC9sPWArUjX12suIZRuH6GskJxDqgUoH1sxt9f9QeepzmpD3yvFO3iHOzwZcxewAvAF5rtnEl+DD4BHnF8X1k29U=;4:6QA5LrBW8hnhPTKFYamk+GaJXc+mIYIHbUSrNfHyDfpe0hW2zMBl+nNiDRTG+ZAcfMBP8Pn3FOKNHMSuZKsAMY4VXI7AolqHTVKE5lYpVNpkN1TqkqaBKeJcgHROhHldKPtO/zpWac2ld+7Gu6AnO3Mx3HfQJG08ypge72U9UeXNvgLxc7YKD/J1283OHnNo8b+1zPWGYuB3ysCG8OsQKQLD5QrMqDf/uqm6hfV7UYgV9/bnzHDGKDxsHuUdMsx/93/DWHGzZzfStZwQXbolNxaEILDiyTNcMXjMK3Zulvrs0iI9uOZLwMYalKmzHBzBTd9SKtmQqG5kKEkJMknbHvmLXTp1OrM8qhaSncEd33CBsUQq7ki1Aoya1s6aL4DMbYXXQpX9AAx6vZu7+VuNNQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001)(102215026);SRVR:CY1PR0301MB1273;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1273; X-Forefront-PRVS: 0744CFB5E8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB1273;23:rnbUFt4jA0spl4Fj3K40D0DlG25diL7ImCbShzq?= =?us-ascii?Q?7BGBqECAvirTwLVi0FSZC3mmMA4RxoolYHsTBglS+a8An28i7XfzRDjf/Qy9?= =?us-ascii?Q?ThCSoNxlfYLmCPubnulJLYnJy6153SEupHqcaW5c868nuJpLjKi1pmIzF9Ro?= =?us-ascii?Q?EFO281ZL1o6IdN/zN/Qb7SWSkvEzY/QLYTAoD7fhO05ZLhseZ1vG3P7V1i6J?= =?us-ascii?Q?InCviolMJbtylLApf+GadBQkI5rB3VWp3VNjsN1vwg1MUgQo7z8dOHvK/6Gx?= =?us-ascii?Q?cWEgkSSnScMY/T103HMsugai3p+vfXMPd0qv6IqQE6rFjYCQ5BkK9vImHUVg?= =?us-ascii?Q?Cx5VYuj/K2wXGtT4EiIm4Esm9OCQOWLsSxx0bU0avO7XMIRrSO2Wmgf/7djr?= =?us-ascii?Q?c3Q6DnXpO/rDJ/v5TrfvStzY8R6JJjGgK4dJP8bF3CiWRVpXpsg6rRfAEl8i?= =?us-ascii?Q?mLxdn0F7pzLZtZEfmHb/5bfEKa53xjiqy1cIfBy2HHF7YnbEa1cowRbK3f0W?= =?us-ascii?Q?1Hply5HP5jJWwo5/no3+NbklbTHQoR7nk09MY0Fa0hy0Ee1lBi1yfFcdSmeK?= =?us-ascii?Q?M1qQ/ruVu5Bb9P7g/IlCE9zpDx7aiRsZ4ICuw34lisqRhqKIVLEnPLYFkIs2?= =?us-ascii?Q?CK4pXvW1UTbsd87XN54Faeh5tWPjEjHsAl5QmkW4mksU/ZDzJvqhVaHeWD7J?= =?us-ascii?Q?CzNyF05MgoyufS+bucmCqjHK+KClcowpEceze/8nELeeSWiTq6l13sfM442C?= =?us-ascii?Q?OvuSgmULSyh606hihwEiX9qqRPPnaGz202aC3BGYzPA+WiF8GvFSbLxOtSJc?= =?us-ascii?Q?XLsanWVPx2TQC4IvSS059gLXopMeEkSfSjWaVFi/dXv8QHjUUXx8ETR6h8Cl?= =?us-ascii?Q?VPDgZue6LOEaO89NAPoKxvROvJcPnufkTDtkp3TQkqp48r6ZL9ow/6mrVqQW?= =?us-ascii?Q?sJgbsKVj9YZwjTyJF6dhVm2amKxxc7a2WxjTM9dopeCWKp3HXAXRAf0vmBRQ?= =?us-ascii?Q?HAvxclV6drLg6/qsZxpSQTorS7YQN8387OXQuQnsIMRjGTUzwxqp/0BdsBO4?= =?us-ascii?Q?6oKJRJBPsA7ua8+1eEZadl21fe2sC?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1273;5:BxiCNwyzlFjdg1CHVrqUHoQPYDo3xiauwrh0DnJHYf7lzHhU2jwHzzwwsH88oBTZ0XYEVqjq9E1AAiChEpCn473whYRLxQqkTNnpf9cgbk7tC1RBRenHDl/WXLB9ObcpHvjSrbE1KE5eCNFC9nGhIA==;24:KA3982KHcfeQxPz9JxddDWPVaaUSpZeBEKT4fb54j40xIqG9fc8sMDCd8zsEqG0LKFBrgJhLcQUI19htbjEf2DzDE5GrrviXTxKk2vX3Lw4=;20:e1s4ymBJ4FluZdL5IxpMN8aGIgyVsCtmBD9GYXG0JtIZ2GfIXi7WCYQjxFGkte4zBAJp2VQ9liMxe2E2eFmlMg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2015 08:09:34.3066 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1273 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2015 at 09:05:55AM +0100, Michal Marek wrote: > Dne 29.10.2015 v 07:34 Peter Chen napsal(a): > > On Wed, Oct 28, 2015 at 02:25:41PM +0100, Michal Marek wrote: > >> From: Michal Marek > >> > >> This allows to write > >> > >> drm-$(CONFIG_AGP) += drm_agpsupport.o > >> > >> without having to handle CONFIG_AGP=y vs. CONFIG_AGP=m. Only support > >> this syntax for modules, since built-in code depending on something > >> modular cannot work and init/Makefile actually relies on the current > >> semantics. There are a few drivers which adapted to the current > >> semantics out of necessity; these are fixed to also work when the > >> respective subsystem is modular. > >> > >> Cc: Peter Chen > >> Cc: linux-usb@vger.kernel.org > >> Cc: Joern Engel > >> Cc: Prasad Joshi > >> Cc: logfs@logfs.org > >> Signed-off-by: Michal Marek > >> --- > >> drivers/misc/ibmasm/ibmasm.h | 2 +- > >> drivers/usb/chipidea/otg_fsm.h | 2 +- > >> fs/logfs/logfs.h | 2 +- > >> scripts/Makefile.build | 8 ++++++-- > >> scripts/Makefile.lib | 4 ++-- > >> 5 files changed, 11 insertions(+), 7 deletions(-) > >> > >> diff --git a/drivers/misc/ibmasm/ibmasm.h b/drivers/misc/ibmasm/ibmasm.h > >> index 9b08344..5bd1277 100644 > >> --- a/drivers/misc/ibmasm/ibmasm.h > >> +++ b/drivers/misc/ibmasm/ibmasm.h > >> @@ -211,7 +211,7 @@ void ibmasmfs_unregister(void); > >> void ibmasmfs_add_sp(struct service_processor *sp); > >> > >> /* uart */ > >> -#ifdef CONFIG_SERIAL_8250 > >> +#if IS_ENABLED(CONFIG_SERIAL_8250) > >> void ibmasm_register_uart(struct service_processor *sp); > >> void ibmasm_unregister_uart(struct service_processor *sp); > >> #else > >> diff --git a/drivers/usb/chipidea/otg_fsm.h b/drivers/usb/chipidea/otg_fsm.h > >> index 2689375..262d6ef 100644 > >> --- a/drivers/usb/chipidea/otg_fsm.h > >> +++ b/drivers/usb/chipidea/otg_fsm.h > >> @@ -62,7 +62,7 @@ > >> /* SSEND time before SRP */ > >> #define TB_SSEND_SRP (1500) /* minimum 1.5 sec, section:5.1.2 */ > >> > >> -#ifdef CONFIG_USB_OTG_FSM > >> +#if IS_ENABLED(CONFIG_USB_OTG_FSM) > > > > Does it mean if the configuration is tristate, it must use IS_ENABLED? > > IS_ENABLED is a shortcut for defined(CONFIG_FOO) || > defined(CONFIG_FOO_MODULE). In other words, it makes sure the that otg > fsm functions are used for both CONFIG_USB_OTG_FSM=y and > CONFIG_USB_OTG_FSM=m. > > Michal > For chipidea changes: Acked-by: Peter Chen -- Best Regards, Peter Chen