From: Peter Chen <peter.chen@freescale.com>
To: Nathan Sullivan <nathan.sullivan@ni.com>
Cc: <gregkh@linuxfoundation.org>, <balbi@ti.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3] usb: remove unnecessary CONFIG_PM dependency from USB_OTG
Date: Thu, 29 Oct 2015 16:25:13 +0800 [thread overview]
Message-ID: <20151029082512.GD8367@shlinux2> (raw)
In-Reply-To: <1446039701-8695-1-git-send-email-nathan.sullivan@ni.com>
On Wed, Oct 28, 2015 at 08:41:41AM -0500, Nathan Sullivan wrote:
> The USB OTG support currently depends on power management
> (CONFIG_PM) being enabled, but does not actually need it enabled.
> Remove this dependency.
>
> Remove the unneeded "default n" from USB_OTG as well, the default is
> already n.
I prefer not to remove it, since most of people may not want to
enable it, you can grep the Kconfig in the kernel source, there
are lots of "default n", especially, it can indicate people that
if they are not sure, set 'n' for it.
Peter
>
> Tested on Bay Trail hardware with dwc3 USB.
>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> ---
> drivers/usb/core/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index a99c89e..567454f 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -43,8 +43,6 @@ config USB_DYNAMIC_MINORS
>
> config USB_OTG
> bool "OTG support"
> - depends on PM
> - default n
> help
> The most notable feature of USB OTG is support for a
> "Dual-Role" device, which can act as either a device
> --
--
Best Regards,
Peter Chen
prev parent reply other threads:[~2015-10-29 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 13:41 [PATCH V3] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Nathan Sullivan
2015-10-29 8:25 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151029082512.GD8367@shlinux2 \
--to=peter.chen@freescale.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nathan.sullivan@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox