* [PATCH V3] usb: remove unnecessary CONFIG_PM dependency from USB_OTG
@ 2015-10-28 13:41 Nathan Sullivan
2015-10-29 8:25 ` Peter Chen
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Sullivan @ 2015-10-28 13:41 UTC (permalink / raw)
To: gregkh, balbi; +Cc: linux-usb, linux-kernel, Nathan Sullivan
The USB OTG support currently depends on power management
(CONFIG_PM) being enabled, but does not actually need it enabled.
Remove this dependency.
Remove the unneeded "default n" from USB_OTG as well, the default is
already n.
Tested on Bay Trail hardware with dwc3 USB.
Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
---
drivers/usb/core/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index a99c89e..567454f 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -43,8 +43,6 @@ config USB_DYNAMIC_MINORS
config USB_OTG
bool "OTG support"
- depends on PM
- default n
help
The most notable feature of USB OTG is support for a
"Dual-Role" device, which can act as either a device
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V3] usb: remove unnecessary CONFIG_PM dependency from USB_OTG
2015-10-28 13:41 [PATCH V3] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Nathan Sullivan
@ 2015-10-29 8:25 ` Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2015-10-29 8:25 UTC (permalink / raw)
To: Nathan Sullivan; +Cc: gregkh, balbi, linux-usb, linux-kernel
On Wed, Oct 28, 2015 at 08:41:41AM -0500, Nathan Sullivan wrote:
> The USB OTG support currently depends on power management
> (CONFIG_PM) being enabled, but does not actually need it enabled.
> Remove this dependency.
>
> Remove the unneeded "default n" from USB_OTG as well, the default is
> already n.
I prefer not to remove it, since most of people may not want to
enable it, you can grep the Kconfig in the kernel source, there
are lots of "default n", especially, it can indicate people that
if they are not sure, set 'n' for it.
Peter
>
> Tested on Bay Trail hardware with dwc3 USB.
>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> ---
> drivers/usb/core/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index a99c89e..567454f 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -43,8 +43,6 @@ config USB_DYNAMIC_MINORS
>
> config USB_OTG
> bool "OTG support"
> - depends on PM
> - default n
> help
> The most notable feature of USB OTG is support for a
> "Dual-Role" device, which can act as either a device
> --
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-29 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-28 13:41 [PATCH V3] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Nathan Sullivan
2015-10-29 8:25 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).