From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756393AbbJ2Imi (ORCPT ); Thu, 29 Oct 2015 04:42:38 -0400 Received: from mail-bl2on0104.outbound.protection.outlook.com ([65.55.169.104]:4890 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756248AbbJ2Ime (ORCPT ); Thu, 29 Oct 2015 04:42:34 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Date: Thu, 29 Oct 2015 16:25:13 +0800 From: Peter Chen To: Nathan Sullivan CC: , , , Subject: Re: [PATCH V3] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Message-ID: <20151029082512.GD8367@shlinux2> References: <1446039701-8695-1-git-send-email-nathan.sullivan@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1446039701-8695-1-git-send-email-nathan.sullivan@ni.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD050;1:kGAt3zBp13Oc32ubnR0S+nEGlIW5kk3bC15sX26ItLkL5s42FKU5TKI0Wk8W2s4Y4CaSXyctl7UHADiN80fO8GkSzbe41H4uW1fXbC4Hyj/dOSfBN7iuBrkZNd1jNe+woGwE25xFPEHwbvPaiOUxc4seylwFXQIlXcsF1ZBvNL4U9npUHkIXchgOvtPu8AZ2bjC8SNBsXf/r/AKOzTGUV6ndSRI3I834n/48bLBvPNImYkmrOUeHWyKOCM9gxuVZbuWuMH3SuIqywMLusiJOTNY/soLc4YEFHepaTc8wvNkTpUhEAesDnZh7GEv1N2AooUfrD4hZ6lXmXW+RcahS+rdM94pevHCxRLxJ74eRtDk/Q54dM/BtScdblqsq520w X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(24454002)(189002)(199003)(92566002)(6806005)(19580395003)(81156007)(97736004)(50466002)(5008740100001)(19580405001)(85426001)(104016004)(23726002)(4001350100001)(2950100001)(77096005)(5007970100001)(11100500001)(86362001)(33656002)(189998001)(87936001)(97756001)(50986999)(105606002)(54356999)(46406003)(47776003)(76176999)(110136002)(106466001)(5001960100002)(33716001)(83506001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB487;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB487;2:FlQtve8hWCjAPSGKa8qZS6xPAxuI6XhF+3SLmWb4EIqDI45EfDH/U15xus3gQS8Zbn4y2uuCf+giMNxW2MJ41d5AlDH+e5tox2xDmYaNl766zDv4k5tsJBMKjnZlBeP2R78kyQblvorEDjEgfXm7CQbh2MCyvknXHdFvpIcNQ4Q=;3:yuqEEt2O1puHXur/HlBOsS6jzXq19uZJP7ak9O1JuX6vhT63ekINnaXEUmEYZK4mrkBKu+9gv21SQwLlwhhiZ9qNe8ZTUvNNwj8YFUm0wX6trlz6LjAxbzMzKxuLt6a/dAD4plk1ih4tEkJpDI7aif5S/xzgCIjkOR1Lw132VCfwHX2qYnn/GtS4GOKTIYWmq94So11JLjOMxlhtOFtjPXN8F23QEHeoFa8J9opXu+A=;25:+Hk8R2wnLI8+eF1ncUTVkbKWJKqspREl6eW1yPXp8vNGu8ennCzFaLF6RcjZR69SJXiXAgETaWrwXpxhGDP9tltJmsIiQofVZyUi1R24WgsCx1ml9JF9rkX3kRZrgsH0GdTlZJW12XUOKOSV0hoaIW+2l25C9xlZauyeNIxm0GVdkDpAhWDOcx0UHvFge1Gz+1/P2dPtB9C9cPmt7ssUHcH7173JyWkG5qGOpE/DhC05zTDkmYlCOc6EqJLW57m5LbrxHOwefx9GQRlSHwRnxg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB487; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB487;20:lO0ZonWSLw4WkkOEeOL0rHRwbmtqGNU0wP0u57MbLYi47AD+YyXoyCOSA+5HrUzzZZ7KKsWvM4FjBmvqsMTi5aBa2TWQc/Txtkx+amXU1N+jhrxnin+ZWx6IPPyLDa3o6IIewvJLdz1B3gtNQ23nHqZSYHf7vJF3mHW4Z25HgEKEMoE7jOP2Ccjny4aXFVH4Dkl9lynmfxglA+aXkCwFWhIh2DlGLeljOVjig0pawJVkoeBGLj30pankcb6Gpq3H3Gqyl5wAnwWKyqGq7GAAR8thmlJ15QqIVZD7iNjVcXDI43MLRE7o+6VNnzmtXjRueJrLWvHSecZEy+Z1H9KYR8bmS5wRRP+pAGq42gILCao=;4:Ugw2cKAkCNbM+TexVcJFkbxpJ/N+9Tkx/PAgxPJJe3W3w1pg8nA8Ae83gWRMIZIdh7idXnWem9pJcfR/R5ZZ7ObZXeguOhJRP/1H7bT9vfBs2UKh1qYSjxk56EaYukJiYk0gxDLxCBmuHpRzMqsJQH6oRRG0PbfywI+rF0IPI6f/izezQb1ACCUqa6ZrFHA6h7VLYTNWHApU3oCRO/AAnZzDqtivdjDe8eE9M2u8etff8AdZbH45aEdDB6UGC0ragifwyTDLdoVV494nIYh7v5SIKPre2vEWdyumaHDXJNgmdZN+JJLS3SGCyrkUQbomqq517ZrZUEGjdUw4HlZMghmzcdALtG1xXpYVmxGdiyrqA7FB6Ocoy26wr+Ab0r9HkTP49us3QIwp+0mKM1hVuQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001)(102215026);SRVR:BLUPR03MB487;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB487; X-Forefront-PRVS: 0744CFB5E8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB487;23:x6EbHe/iz9uV/sJbnSO+0IKIa1yQgp+LGDmXazLMF9?= =?us-ascii?Q?FhY/eNFek4+P3aca7iuVM+vKofNI/IlG0x9hjtJ5s8CZ1wP+z7vMHSRTRmwN?= =?us-ascii?Q?Z5txbQEXIrQbLWXFYyj9AEg4VU3r3Y1SlrWze78eeYFP0jvYPmyTt09lUFl8?= =?us-ascii?Q?IgfiRkbJ+NURHstkt0Bax7azwlPzv70ksksYVr30/EZe11wEp9d+V7Ielp8x?= =?us-ascii?Q?yafNCToVfbLHEeTeMStQsV6pA+x7U7Lo1t7BIL5hAVDtjybv2OBWASSkTcIU?= =?us-ascii?Q?Z24M41gO8sud9c2CDMTkc5L+1nZCdhCcyfMHdQ3JhS/1P/HH+JRj6AyAJ1vL?= =?us-ascii?Q?7TXnqvQrXRT8FRqe7fvbJ6qejNBov0YPsUHIOJlIkyhOglL3WIK3mY9TZr6T?= =?us-ascii?Q?yjH8ZNEY5l1rUYsvREqHLx+Yj3qjFYSJmZH9BT4rkotD1bTYhjj5LfcEYLbu?= =?us-ascii?Q?yvILBYGNP8IybosfK7i+F3UC6tOjsFEYrD8YCyuk6HUW+vTsT1TkmKTwGARV?= =?us-ascii?Q?BZ1FFWps6yWXztyliU6hL3ymCKil25l1//V8RM/BzooJIRhDTP7GVu9qt+1I?= =?us-ascii?Q?xDDt6KIhMgpBU+tfvwRcZ1VMIiijeXoiPIeA4BljyMp2XbnW2vIv2kEum113?= =?us-ascii?Q?Fh6blGqbd0onaJSNGKrempnibl9fK4ykrZCh0QUVpJgE5s+V9qc6bdRZmMl9?= =?us-ascii?Q?B2Q3f1RBZXB4zE5SuZZwdYfjlrtzT/+SDPtoLZT/+gLArLpwU2jyye6CgmpH?= =?us-ascii?Q?Ar9Ur4plEBys+uL+cFwcA9jRd06wzB3w7mNa8e12bXVhcyt8U8zHfa8MfhNS?= =?us-ascii?Q?ye4Hcj+QUUl77OiAENj0fvltDd4vEGSUxms1j/zX5Qaix0D4s3iHI6oX3utd?= =?us-ascii?Q?TpMg6fsZKXJl35s5iDK814o8bB1D+pmHpVk4Cxw/Q7as0DJvrtxFXV+N/okH?= =?us-ascii?Q?Hna619nXDS/OaAXWdZ/P/9fcPj45iKNCs0g1aR7L5bB6C4t7v7MqfB3ruEAD?= =?us-ascii?Q?ax3SLmpTLQ88q9nEbGpJ3jZb4yU6SXm7ZlkO/r1EftXIrUVW0k8BX0TpYYl9?= =?us-ascii?Q?PwpCWj2lqNZrjWiMSxuax4cwEq?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB487;5:tniE77l1lrhlJxgsddDj1jx2+ISBJSs8BrqOYFH6AJnPeoGwOmlF7knqrSweKPLrILi5cSABuJce3kVDCOJchXONL4uZY/qkqe9QgK88CNmonFEoRaxGIROQ2oO8wPaXfxfMN1CSd4I290KFpza75g==;24:/j681XJ/AuqEtkVb3Iq4Zr9T5VRD+ADmPiSnZdP1Zit30jdElaFMxIyc+Lt+P7yEmxnkTS7+ouwNtTJ252ESw3QeYYwxOrFDdRqGiG64YIo=;20:ExcFqqakSZVVD9koe1fFOwI87nW/5q+QrAKIsFGQqWvvywYqbxy9JA7P2vo5XKK76e1PGepsWC+9jZ82X82YEg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2015 08:26:50.6758 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB487 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 08:41:41AM -0500, Nathan Sullivan wrote: > The USB OTG support currently depends on power management > (CONFIG_PM) being enabled, but does not actually need it enabled. > Remove this dependency. > > Remove the unneeded "default n" from USB_OTG as well, the default is > already n. I prefer not to remove it, since most of people may not want to enable it, you can grep the Kconfig in the kernel source, there are lots of "default n", especially, it can indicate people that if they are not sure, set 'n' for it. Peter > > Tested on Bay Trail hardware with dwc3 USB. > > Signed-off-by: Nathan Sullivan > --- > drivers/usb/core/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig > index a99c89e..567454f 100644 > --- a/drivers/usb/core/Kconfig > +++ b/drivers/usb/core/Kconfig > @@ -43,8 +43,6 @@ config USB_DYNAMIC_MINORS > > config USB_OTG > bool "OTG support" > - depends on PM > - default n > help > The most notable feature of USB OTG is support for a > "Dual-Role" device, which can act as either a device > -- -- Best Regards, Peter Chen