From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756430AbbJ2JUR (ORCPT ); Thu, 29 Oct 2015 05:20:17 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:35961 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755488AbbJ2JUM (ORCPT ); Thu, 29 Oct 2015 05:20:12 -0400 Date: Thu, 29 Oct 2015 09:20:07 +0000 From: Lee Jones To: Joe Perches Cc: Krzysztof Kozlowski , Andrew Morton , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , k.kozlowski.k@gmail.com, wsa@the-dreams.de, linus.walleij@linaro.org, Sebastian Reichel , linux-kernel@vger.kernel.org, Chanwoo Choi , broonie@kernel.org, ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] get_maintainer: Add subsystem to reviewer output Message-ID: <20151029092007.GN4058@x1> References: <20151028093907.GP4931@pengutronix.de> <20151028095524.GP5828@x1> <5630CA06.7050503@samsung.com> <1446050506.2757.109.camel@perches.com> <20151028170116.GI4058@x1> <1446052121.2757.120.camel@perches.com> <20151028172208.GJ4058@x1> <1446053411.2757.131.camel@perches.com> <20151028174932.GK4058@x1> <1446054996.2757.139.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1446054996.2757.139.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2015, Joe Perches wrote: > On Wed, 2015-10-28 at 17:49 +0000, Lee Jones wrote: > > On Wed, 28 Oct 2015, Joe Perches wrote: > > > On Wed, 2015-10-28 at 17:22 +0000, Lee Jones wrote: > > > > On Wed, 28 Oct 2015, Joe Perches wrote: > > > > > > Acked-by: Lee Jones > > > > > It'd be better if you could add a "tested-by:" instead. > > > > > > > > Patch works as expected: > > > > Tested-by: Lee Jones > > > [] > > > > "I'm sure we can make the output even more similar by listing > > > > the MAINTAINERS tag after "reviewer" too." > > > > > > I guess we'll disagree on that one too. > > > > You just happened to think of it a few hours after I mentioned it. > > Nope, it seems a maintainers tag is what Krzysztof was suggesting > with his "supported reviewer" bit. Which was in reply to the bit above. > I added the subsystem name. (subsystem name == MAINTAINERS tag) in my comment above. > An issue for that will be how multiple subsystem section matching > affects the output for reviewers who are also maintainers. I think that's okay, becuase the 'MAINTAINERS tag' will be different. As an example: Lee Jones (supporter:DRIVER SUBSYSTEM) Lee Jones (reviewer:VENDOR DRIVER NAME) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog