From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757224AbbJ2SvF (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Oct 2015 14:51:05 -0400
Received: from asavdk4.altibox.net ([109.247.116.15]:59881 "EHLO
	asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753388AbbJ2SvE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Oct 2015 14:51:04 -0400
Date: Thu, 29 Oct 2015 19:50:56 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Nitin Gupta <nitin.m.gupta@oracle.com>
Cc: sparclinux <sparclinux@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        Chris Hyser <chris.hyser@oracle.com>,
        Khalid Aziz <khalid.aziz@oracle.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        David Hildenbrand <dahi@linux.vnet.ibm.com>,
        Tony Luck <tony.luck@intel.com>,
        Santosh Shilimkar <santosh.shilimkar@oracle.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sparc64: Fix numa distance values
Message-ID: <20151029185056.GA398@ravnborg.org>
References: <1446077026-5598-1-git-send-email-nitin.m.gupta@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1446077026-5598-1-git-send-email-nitin.m.gupta@oracle.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.1 cv=OIGHpXuB c=1 sm=1 tr=0
	a=Ij76tQDYWdb01v2+RnYW5w==:117 a=Ij76tQDYWdb01v2+RnYW5w==:17
	a=7gkXJVJtAAAA:8 a=Git7GJnPAAAA:8 a=kj9zAlcOel0A:10
	a=xIApM3LaGIP4IRB8X80A:9 a=CjuIK1q_8ugA:10
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Small nit.

> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
> index 01d1704..ed3dfdd 100644
> --- a/arch/sparc/include/asm/topology_64.h
> +++ b/arch/sparc/include/asm/topology_64.h
> @@ -31,6 +31,9 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
>  	 cpu_all_mask : \
>  	 cpumask_of_node(pcibus_to_node(bus)))
>  
> +extern int __node_distance(int, int);
We have dropped using "extern" for function prototypes.

> +#define node_distance(a, b) __node_distance(a, b)

And had this be written as:
#define node_distance node_distance
int node_distance(int, int);

Then there had been no need for the leadign underscores.

But as I said - only nits.

	Sam