From: Jiaxing Wang <hello.wjx@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when filtering pids
Date: Fri, 30 Oct 2015 14:16:43 +0800 [thread overview]
Message-ID: <20151030061643.GA19480@cac> (raw)
In-Reply-To: <20151029071032.334291716@goodmis.org>
On Thu, Oct 29, 2015 at 03:07:58AM -0400, Steven Rostedt wrote:
> static ssize_t
> ftrace_event_pid_write(struct file *filp, const char __user *ubuf,
> size_t cnt, loff_t *ppos)
> @@ -1711,6 +1727,12 @@ ftrace_event_pid_write(struct file *filp, const char __user *ubuf,
> tr, INT_MAX);
> register_trace_prio_sched_wakeup(event_filter_pid_sched_wakeup_probe_post,
> tr, 0);
> +
> + /*
> + * Ignoring of pids is done at task switch. But we have to
> + * check for those tasks that are currently running.
> + */
> + on_each_cpu(ignore_task_cpu, tr, 1);
> }
on_each_cpu(ignore_task_cpu, tr, 1); can be put outside of the else
block, then ignore_pid can be updated when appending pid,
eg. echo 'xxx' >> set_event_pid, in case xxx is running on some cpu.
>
> mutex_unlock(&event_mutex);
next prev parent reply other threads:[~2015-10-30 6:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 7:07 [for-next][PATCH 0/5] tracing: Addition of set_event_pid Steven Rostedt
2015-10-29 7:07 ` [for-next][PATCH 1/5] tracepoint: Give priority to probes of tracepoints Steven Rostedt
2015-10-29 17:52 ` Mathieu Desnoyers
2015-10-30 20:25 ` Steven Rostedt
2015-10-30 20:49 ` Mathieu Desnoyers
2015-10-29 7:07 ` [for-next][PATCH 2/5] tracing: Add set_event_pid directory for future use Steven Rostedt
2015-11-19 23:24 ` Paul E. McKenney
2015-11-20 4:17 ` Steven Rostedt
2015-12-01 18:12 ` Paul E. McKenney
2015-10-29 7:07 ` [for-next][PATCH 3/5] tracing: Implement event pid filtering Steven Rostedt
2015-10-29 7:07 ` [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when filtering pids Steven Rostedt
2015-10-30 6:16 ` Jiaxing Wang [this message]
2015-10-30 20:28 ` Steven Rostedt
2015-10-29 7:07 ` [for-next][PATCH 5/5] tracing: Fix sparse RCU warning Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030061643.GA19480@cac \
--to=hello.wjx@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).