From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030652AbbJ3I7h (ORCPT ); Fri, 30 Oct 2015 04:59:37 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36679 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030599AbbJ3I7e (ORCPT ); Fri, 30 Oct 2015 04:59:34 -0400 Date: Fri, 30 Oct 2015 09:59:19 +0100 From: Bogicevic Sasa To: Sudip Mukherjee Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drivers:staging:gdm724x Fill all alignment should match open parentheses Message-ID: <20151030085919.GA3525@gmail.com> References: <1446149701-3149-1-git-send-email-brutallesale@gmail.com> <20151030073114.GC31483@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20151030073114.GC31483@sudip-pc> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2015, Sudip Mukherjee wrote: >On Thu, Oct 29, 2015 at 09:15:01PM +0100, Bogicevic Sasa wrote: >> This fixes all errors about alignment with open parentheses as well as >> one spacing needed around "-" sign since the patch would not be valid if >> I left it there > >1) That becomes two different type of change. >2) This has already been done by >a4785ef81023 ("staging: gdm724x: properly indent to match open paranthesis") >I think you need to refresh your tree against current staging tree. > >3) your patch subject says 2/2, the next patch says 3/3 and the one >after that is saying 4/4. There is something wrong in the way you are >generating the patches. This 2/2 or 3/3 should not be here unless you >are sending a series of patch. > >regards >sudip Ok 1) When I changed the alignment in one of the lines then checkpatch.pl starts complaining about the spaces in the same line so what do you do in that situation a) just submit anyway or b) fix it I guess a according to your email 2) I'll see what the hell did I do to not notice this 3) I just pull, make a change, commit and do git format-patch master..somebranch. Do I need to create separate branches for all issues? Thanks!