From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759540AbbJ3Jbk (ORCPT ); Fri, 30 Oct 2015 05:31:40 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:34056 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbbJ3Jbi (ORCPT ); Fri, 30 Oct 2015 05:31:38 -0400 Date: Fri, 30 Oct 2015 09:31:30 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Sangbeom Kim , Chanwoo Choi , Javier Martinez Canillas , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children Message-ID: <20151030093130.GR4058@x1> References: <1446191481-21214-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1446191481-21214-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Oct 2015, Krzysztof Kozlowski wrote: > The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02 > device") added new MFD child devices for S2MPU02: RTC and clock > provider (the clock provider with new compatible). However support for > these devices was not added to existing drivers (rtc-s5m, clk-s2mps11). > New drivers were not submitted neither. > > This means that the name of children devices is completely unused. The > "samsung,s2mpu02-clk" compatible remains undocumented so it is unclear > what is provided by that compatible. > > Clean up this by removing unused child devices and undocumented > compatible. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I don't think that removing the "samsung,s2mpu02-clk" compatible would > be considered as ABI break because: > 1. Kernel did not document it as ABI. > 2. Kernel did not provide any kind of feature for that compatible. It > was totally ignored. > --- > drivers/mfd/sec-core.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 2626fc0b5b8c..989076d6cb83 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -103,12 +103,9 @@ static const struct mfd_cell s2mpa01_devs[] = { > }; > > static const struct mfd_cell s2mpu02_devs[] = { > - { .name = "s2mpu02-pmic", }, > - { .name = "s2mpu02-rtc", }, > { > - .name = "s2mpu02-clk", > - .of_compatible = "samsung,s2mpu02-clk", > - } > + .name = "s2mpu02-pmic", > + }, > }; > > #ifdef CONFIG_OF -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog