From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030720AbbJ3LQZ (ORCPT ); Fri, 30 Oct 2015 07:16:25 -0400 Received: from foss.arm.com ([217.140.101.70]:43195 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030667AbbJ3LQY (ORCPT ); Fri, 30 Oct 2015 07:16:24 -0400 Date: Fri, 30 Oct 2015 11:16:19 +0000 From: Will Deacon To: AKASHI Takahiro Cc: catalin.marinas@arm.com, rostedt@goodmis.org, jungseoklee85@gmail.com, olof@lixom.net, broonie@kernel.org, david.griego@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/6] arm64: ftrace: adjust callsite addresses examined by stack tracer Message-ID: <20151030111618.GA20030@arm.com> References: <1446182741-31019-1-git-send-email-takahiro.akashi@linaro.org> <1446182741-31019-2-git-send-email-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446182741-31019-2-git-send-email-takahiro.akashi@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2015 at 02:25:36PM +0900, AKASHI Takahiro wrote: > On arm64, no PC values returned by save_stack_trace() will match to LR > values saved in stack frames on a stack after the following commit: > commit e306dfd06fcb ("ARM64: unwind: Fix PC calculation") > As a result, the output from stack tracer will be messed up. FWIW, we've decided to revert that patch for the moment. We're the only architecture making that kind of adjustment, so we should fix that before building on top of it. Will