From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751564AbbJ3MYU (ORCPT ); Fri, 30 Oct 2015 08:24:20 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38222 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbbJ3MYT (ORCPT ); Fri, 30 Oct 2015 08:24:19 -0400 Date: Fri, 30 Oct 2015 12:24:10 +0000 From: Lee Jones To: Alim Akhtar Cc: broonie@kernel.org, k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] regulator: s2mps11: Rename s2mpsxx regulator as *-regulator Message-ID: <20151030122409.GS4058@x1> References: <1446202913-20467-1-git-send-email-alim.akhtar@samsung.com> <1446202913-20467-2-git-send-email-alim.akhtar@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1446202913-20467-2-git-send-email-alim.akhtar@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Oct 2015, Alim Akhtar wrote: > S2MPSXX regulators are probed with the same name as their parent MFD > device, this is a bit confusing. > As we discussed the same here[1], this patch rename the current regulator > names from *-pmic to *-regulator. > > [1]-> https://lkml.org/lkml/2015/10/28/417 > > Suggested-by: Lee Jones > Signed-off-by: Alim Akhtar > --- > drivers/regulator/s2mps11.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) You need to squash these patches together, or you will hurt bisectability for your platform. But the code looks good: Acked-by: Lee Jones > diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c > index b2f3a28e720c..3242ffc0cb25 100644 > --- a/drivers/regulator/s2mps11.c > +++ b/drivers/regulator/s2mps11.c > @@ -1199,11 +1199,11 @@ out: > } > > static const struct platform_device_id s2mps11_pmic_id[] = { > - { "s2mps11-pmic", S2MPS11X}, > - { "s2mps13-pmic", S2MPS13X}, > - { "s2mps14-pmic", S2MPS14X}, > + { "s2mps11-regulator", S2MPS11X}, > + { "s2mps13-regulator", S2MPS13X}, > + { "s2mps14-regulator", S2MPS14X}, > { "s2mps15-regulator", S2MPS15X}, > - { "s2mpu02-pmic", S2MPU02}, > + { "s2mpu02-regulator", S2MPU02}, > { }, > }; > MODULE_DEVICE_TABLE(platform, s2mps11_pmic_id); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog