* [PATCH] reset: sunxi: mark the of_device_id array as __initconst
@ 2015-10-29 9:10 Philipp Zabel
2015-10-30 16:42 ` Maxime Ripard
2015-11-02 7:29 ` Uwe Kleine-König
0 siblings, 2 replies; 3+ messages in thread
From: Philipp Zabel @ 2015-10-29 9:10 UTC (permalink / raw)
To: linux-kernel; +Cc: Maxime Ripard, kernel, Philipp Zabel
Since this array is static const, it should be marked as __initconst.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/reset-sunxi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
index df58e71..58ddb26 100644
--- a/drivers/reset/reset-sunxi.c
+++ b/drivers/reset/reset-sunxi.c
@@ -140,7 +140,7 @@ static int sun8i_h3_bus_reset_xlate(struct reset_controller_dev *rcdev,
* our system, before we can even think of using a regular device
* driver for it.
*/
-static const struct of_device_id sunxi_early_reset_dt_ids[] __initdata = {
+static const struct of_device_id sunxi_early_reset_dt_ids[] __initconst = {
{ .compatible = "allwinner,sun6i-a31-ahb1-reset", },
{ .compatible = "allwinner,sun8i-h3-bus-reset", .data = sun8i_h3_bus_reset_xlate, },
{ /* sentinel */ },
--
2.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] reset: sunxi: mark the of_device_id array as __initconst
2015-10-29 9:10 [PATCH] reset: sunxi: mark the of_device_id array as __initconst Philipp Zabel
@ 2015-10-30 16:42 ` Maxime Ripard
2015-11-02 7:29 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2015-10-30 16:42 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, kernel
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
On Thu, Oct 29, 2015 at 10:10:17AM +0100, Philipp Zabel wrote:
> Since this array is static const, it should be marked as __initconst.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] reset: sunxi: mark the of_device_id array as __initconst
2015-10-29 9:10 [PATCH] reset: sunxi: mark the of_device_id array as __initconst Philipp Zabel
2015-10-30 16:42 ` Maxime Ripard
@ 2015-11-02 7:29 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2015-11-02 7:29 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Maxime Ripard, kernel
Hello Philipp,
On Thu, Oct 29, 2015 at 10:10:17AM +0100, Philipp Zabel wrote:
> Since this array is static const, it should be marked as __initconst.
independent of your change sunxi_reset_init can be moved to .init.text,
too.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-02 7:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-29 9:10 [PATCH] reset: sunxi: mark the of_device_id array as __initconst Philipp Zabel
2015-10-30 16:42 ` Maxime Ripard
2015-11-02 7:29 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox