Re: [PATCH v5 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC

Lee Jones
2015-10-30T17:10:52Z

On Fri, 30 Oct 2015, Linus Walleij wrote:

> On Fri, Oct 30, 2015 at 12:38 AM, Andrew F. Davis <afd@ti.com> wrote:
>
> > This patch adds support for the TPS65912 PMIC GPIOs.
> >
> > TPS65912 has five configurable GPIOs that can be used for several
> > purposes.
> >
> > Signed-off-by: Andrew F. Davis <afd@ti.com>
>
> This looks like a fine driver, can't really see anything wrong with it so:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> > +#define to_tps65912_gpio(gc) container_of(gc, struct tps65912_gpio, gpio_chip)
>
> I would rewrite that to static inline however.
>
> Lee can take this into the MFD tree with my review-tag if he wants.

Please fix this, then resubmit the set with Acks/Reviewed-by's applied.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog