From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760245AbbJ3SND (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Oct 2015 14:13:03 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:41086 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751254AbbJ3SNB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Oct 2015 14:13:01 -0400
Date: Fri, 30 Oct 2015 14:12:54 -0400
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
        shannon.nelson@intel.com, carolyn.wyborny@intel.com,
        donald.c.skidmore@intel.com, matthew.vick@intel.com,
        john.ronciak@intel.com, mitch.a.williams@intel.com
Subject: Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or
 IDPROM
Message-ID: <20151030181254.GC32759@oracle.com>
References: <20151030150344.GG9312@oracle.com>
 <CAHp75Vc-swMap+Umong1WVfL-fQNNZ9QEXvrHCJXCte1g_h_KA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vc-swMap+Umong1WVfL-fQNNZ9QEXvrHCJXCte1g_h_KA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (10/30/15 20:06), Andy Shevchenko wrote:
> 
> > +#include "i40e.h"
> 
> Why do you need this one exactly?

I needed it to find pf->pdev below.

> > +       struct device_node *dp = pci_device_to_OF_node(pf->pdev);

Without it, you will get:
              :
     CC [M]  drivers/net/ethernet/intel/i40e/i40e_common.o
   drivers/net/ethernet/intel/i40e/i40e_common.c: In function ?i40e_get_platform_mac_addr?:
   drivers/net/ethernet/intel/i40e/i40e_common.c:1021: error: dereferencing pointer to incomplete type


Unless you feel passionately about the \n nits, I'm going to pass on those. 
Thanks for reviewing.

--Sowmini