From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760172AbbJ3St2 (ORCPT ); Fri, 30 Oct 2015 14:49:28 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:36919 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759930AbbJ3StL (ORCPT ); Fri, 30 Oct 2015 14:49:11 -0400 Date: Fri, 30 Oct 2015 18:49:03 +0000 From: Lee Jones To: Bjorn Andersson Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Rob Clark , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [RESEND PATCH v2] backlight: pm8941-wled: Add default-brightness property Message-ID: <20151030184903.GK4058@x1> References: <1445881508-18025-1-git-send-email-bjorn.andersson@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1445881508-18025-1-git-send-email-bjorn.andersson@sonymobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Oct 2015, Bjorn Andersson wrote: > Default the brightness to 2048 and add possibility to override this in > device tree. > > Suggested-by: Rob Clark > Signed-off-by: Bjorn Andersson > --- > > Resend of v2, with updated backlight dt binding location. > > Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt | 2 ++ In future please submit documentation as a separate patch. > drivers/video/backlight/pm8941-wled.c | 8 ++++++++ > 2 files changed, 10 insertions(+) Applied with Rob's Ack. > diff --git a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt b/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt > index 424f8444a6cd..e5b294dafc58 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt > +++ b/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt > @@ -5,6 +5,8 @@ Required properties: > - reg: slave address > > Optional properties: > +- default-brightness: brightness value on boot, value from: 0-4095 > + default: 2048 > - label: The name of the backlight device > - qcom,cs-out: bool; enable current sink output > - qcom,cabc: bool; enable content adaptive backlight control > diff --git a/drivers/video/backlight/pm8941-wled.c b/drivers/video/backlight/pm8941-wled.c > index c704c3236034..e1298147bcbb 100644 > --- a/drivers/video/backlight/pm8941-wled.c > +++ b/drivers/video/backlight/pm8941-wled.c > @@ -17,6 +17,9 @@ > #include > #include > > +/* From DT binding */ > +#define PM8941_WLED_DEFAULT_BRIGHTNESS 2048 > + > #define PM8941_WLED_REG_VAL_BASE 0x40 > #define PM8941_WLED_REG_VAL_MAX 0xFFF > > @@ -373,6 +376,7 @@ static int pm8941_wled_probe(struct platform_device *pdev) > struct backlight_device *bl; > struct pm8941_wled *wled; > struct regmap *regmap; > + u32 val; > int rc; > > regmap = dev_get_regmap(pdev->dev.parent, NULL); > @@ -395,8 +399,12 @@ static int pm8941_wled_probe(struct platform_device *pdev) > if (rc) > return rc; > > + val = PM8941_WLED_DEFAULT_BRIGHTNESS; > + of_property_read_u32(pdev->dev.of_node, "default-brightness", &val); > + > memset(&props, 0, sizeof(struct backlight_properties)); > props.type = BACKLIGHT_RAW; > + props.brightness = val; > props.max_brightness = PM8941_WLED_REG_VAL_MAX; > bl = devm_backlight_device_register(&pdev->dev, wled->name, > &pdev->dev, wled, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog