From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759417AbbJ3LNl (ORCPT ); Fri, 30 Oct 2015 07:13:41 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:1342 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758989AbbJ3LNk (ORCPT ); Fri, 30 Oct 2015 07:13:40 -0400 Date: Fri, 30 Oct 2015 19:09:29 +0800 From: Jisheng Zhang To: Daniel Lezcano CC: , , Subject: Re: [PATCH] clocksource: dw_apb_timer_of: support timer-based delay Message-ID: <20151030190929.4c46066c@xhacker> In-Reply-To: <56334A1E.7060709@linaro.org> References: <1446193659-1698-1-git-send-email-jszhang@marvell.com> <56334A1E.7060709@linaro.org> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-30_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1510300202 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Daniel, On Fri, 30 Oct 2015 11:44:46 +0100 Daniel Lezcano wrote: > On 10/30/2015 09:27 AM, Jisheng Zhang wrote: > > Implement an ARM delay timer to be used for udelay(). This allows us to > > skip the delay loop calibration at boot on Marvell BG2, BG2Q, BG2CD > > platforms. And after this patch, udelay() will be unaffected by CPU > > frequency changes. > > > > Signed-off-by: Jisheng Zhang > > --- > > drivers/clocksource/Kconfig | 10 ++++++++++ > > drivers/clocksource/dw_apb_timer_of.c | 16 ++++++++++++++++ > > 2 files changed, 26 insertions(+) > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > index a7726db..7b081805 100644 > > --- a/drivers/clocksource/Kconfig > > +++ b/drivers/clocksource/Kconfig > > @@ -29,6 +29,16 @@ config DW_APB_TIMER_OF > > select DW_APB_TIMER > > select CLKSRC_OF > > > > +config DW_APB_TIMER_BASED_DELAY > > + bool "DW APB timer based delay" > > + depends on ARM && DW_APB_TIMER_OF > > + default n > > + help > > + This option enables support for using the DW APB timer to > > + implement timer-based delay. It is useful for skiping the > > + delay loop calibration at boot on some platforms. And the > > + udelay() will be unaffected by CPU frequency changes. > > + > > Why do you want it to be optional ? > Because in some platforms which has arm arch timer, this dw apb timer delay isn't needed, the arch timer is better. So we want it be optional so that the platforms which need this feature select it manually when config the kernel. Thanks, Jisheng