From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754472AbbJaBjV (ORCPT ); Fri, 30 Oct 2015 21:39:21 -0400 Received: from mga02.intel.com ([134.134.136.20]:61245 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016AbbJaBjT (ORCPT ); Fri, 30 Oct 2015 21:39:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,221,1444719600"; d="scan'208";a="808047845" Date: Sat, 31 Oct 2015 07:12:44 +0530 From: Vinod Koul To: Han Xu Cc: shijie.huang@arm.com, dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, fabio.estevam@freescale.com, hofrat@osadl.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, dan.j.williams@intel.com, dmaengine@vger.kernel.org Subject: Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode Message-ID: <20151031014244.GF21326@localhost> References: <1445983540-27155-1-git-send-email-b45815@freescale.com> <1445983540-27155-3-git-send-email-b45815@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445983540-27155-3-git-send-email-b45815@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2015 at 05:05:35PM -0500, Han Xu wrote: > > -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma) > +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma) This change seems unrelated to patch description, can you explain why? > +#ifdef CONFIG_PM_SLEEP > +static int mxs_dma_pm_resume(struct device *dev) > +{ > + struct mxs_dma_engine *mxs_dma = dev_get_drvdata(dev); > + int ret; > + > + ret = mxs_dma_init(mxs_dma); > + if (ret) > + return ret; > + return 0; why not return mxs_dma_init() then! -- ~Vinod