From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753828AbbJaCUL (ORCPT ); Fri, 30 Oct 2015 22:20:11 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35725 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759AbbJaCUI (ORCPT ); Fri, 30 Oct 2015 22:20:08 -0400 Date: Sat, 31 Oct 2015 07:50:03 +0530 From: Viresh Kumar To: Stephen Boyd Cc: Rafael Wysocki , robh+dt@kernel.org, lee.jones@linaro.org, linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, nm@ti.com, devicetree@vger.kernel.org, open list , "Rafael J. Wysocki" Subject: Re: [PATCH 1/3] PM / OPP: Add "opp-supported-hw" binding Message-ID: <20151031022003.GV3716@ubuntu> References: <2d52388bd7d3cc546ac3ab5afeb47bfcb3012213.1446167359.git.viresh.kumar@linaro.org> <20151030221826.GM19782@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151030221826.GM19782@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30-10-15, 15:18, Stephen Boyd wrote: > A side-note. I wonder if it would be better style to have the > node name be: > > opp@600000000 { I thought the @... had a special meaning and we might end up creating some device for the node then? Perhaps I am mistaken. But then, yeah it will make it more readable as you mentioned. > At least it seems that the assumption is we can store all the > possible combinations of OPP values for a particular frequency in > the same node. Following this style would make dt compilation > fail if two nodes have the same frequency. Right. > Also, this makes it sound like opp-supported-hw is really just > telling us if this is a supported frequency or not for the > particular device we're running on. That's right. > The current wording makes it Of the commit log ? Or the way the nodes are written? > sound like we could have two OPP nodes with the same frequency > but different voltages inside them, which we're trying to > discourage by compressing the tables into less nodes. No no, we can't have two nodes with same frequency. -- viresh