From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
David Ahern <dsahern@gmail.com>
Subject: Re: [RFC/PATCH 5/5] perf report: Fix segfault on -g fractral with --stdio
Date: Sat, 31 Oct 2015 12:09:46 +0100 [thread overview]
Message-ID: <20151031110946.GA5858@krava.redhat.com> (raw)
In-Reply-To: <1446225338-20431-6-git-send-email-namhyung@kernel.org>
On Sat, Oct 31, 2015 at 02:15:38AM +0900, Namhyung Kim wrote:
SNIP
>
> if (!rem_sq_bracket)
> return ret;
>
> + if (callchain_param.value == CCVAL_COUNT) {
> + rem_node.count = child->parent->children_count - cumul_count;
> + if (rem_node.count <= 0)
> + return ret;
> + }
> +
> new_depth_mask &= ~(1 << (depth - 1));
> - ret += ipchain__fprintf_graph(fp, NULL, &rem_hits, depth,
> + ret += ipchain__fprintf_graph(fp, &rem_node, &rem_hits, depth,
> new_depth_mask, 0, total_samples,
> left_margin);
this looks like being introduced within your patchset in patch:
perf callchain: Abstract callchain print function
shouldn't it get fixed in there?
jirka
next prev parent reply other threads:[~2015-10-31 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 17:15 [RFC/PATCH 0/5] perf report: Support folded callchain output (v1) Namhyung Kim
2015-10-30 17:15 ` [RFC/PATCH 1/5] perf report: Support folded callchain mode on --stdio Namhyung Kim
2015-10-30 17:15 ` [RFC/PATCH 2/5] perf callchain: Abstract callchain print function Namhyung Kim
2015-10-30 17:15 ` [RFC/PATCH 3/5] perf callchain: Add count fields to struct callchain_node Namhyung Kim
2015-10-30 17:15 ` [RFC/PATCH 4/5] perf report: Add callchain value option Namhyung Kim
2015-10-30 17:15 ` [RFC/PATCH 5/5] perf report: Fix segfault on -g fractral with --stdio Namhyung Kim
2015-10-31 11:09 ` Jiri Olsa [this message]
2015-11-02 6:45 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151031110946.GA5858@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=brendan.d.gregg@gmail.com \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox