From: Johan Hovold <johan@kernel.org>
To: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug
Date: Sat, 31 Oct 2015 13:16:12 +0100 [thread overview]
Message-ID: <20151031121612.GC2636@localhost> (raw)
In-Reply-To: <CAL_jEz9PA9eLMXuX7MnAzPOwecCpSKZh54nNttudK=E=821J8Q@mail.gmail.com>
[ Please avoid top-posting. ]
On Thu, Oct 29, 2015 at 08:39:04AM -0500, Konstantin Shkolnyy wrote:
> I tested it on cp2102, cp2105 and cp2108.
> I'm a little worried about that extra PURGE command, so I did several
> manual tests on each with a standard PC serial port on the other end
> of the cable.
> - run several open/write/close iteration (the test that used to break
> cp2108), observe data on the other end;
> - open minicom and see that cp210x can still receive data from the other end.
Sounds good.
If this turns out to cause any problems, we can always enable this based
on chip type, right? I saw something about a vendor request for that in
your (silabs') vendor driver.
> BTW, can you suggest (preferably automated) serial port test s/w?
No, sorry. I have a bunch of test code that I intend to organise and
clean up at some point, but I never seem to find the time to actually do
it.
Johan
next prev parent reply other threads:[~2015-10-31 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 21:53 [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug Konstantin Shkolnyy
2015-10-28 8:51 ` Johan Hovold
2015-10-29 7:19 ` Johan Hovold
2015-10-29 13:39 ` Konstantin Shkolnyy
2015-10-31 12:16 ` Johan Hovold [this message]
2015-10-31 14:54 ` Konstantin Shkolnyy
2015-11-03 13:26 ` Konstantin Shkolnyy
2015-11-03 13:33 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151031121612.GC2636@localhost \
--to=johan@kernel.org \
--cc=konstantin.shkolnyy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox