From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753374AbbJaMQN (ORCPT ); Sat, 31 Oct 2015 08:16:13 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:36404 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752988AbbJaMQL (ORCPT ); Sat, 31 Oct 2015 08:16:11 -0400 Date: Sat, 31 Oct 2015 13:16:12 +0100 From: Johan Hovold To: Konstantin Shkolnyy Cc: Johan Hovold , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug Message-ID: <20151031121612.GC2636@localhost> References: <1445982814-11638-1-git-send-email-konstantin.shkolnyy@gmail.com> <20151028085126.GA28572@localhost> <20151029071923.GD32753@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Please avoid top-posting. ] On Thu, Oct 29, 2015 at 08:39:04AM -0500, Konstantin Shkolnyy wrote: > I tested it on cp2102, cp2105 and cp2108. > I'm a little worried about that extra PURGE command, so I did several > manual tests on each with a standard PC serial port on the other end > of the cable. > - run several open/write/close iteration (the test that used to break > cp2108), observe data on the other end; > - open minicom and see that cp210x can still receive data from the other end. Sounds good. If this turns out to cause any problems, we can always enable this based on chip type, right? I saw something about a vendor request for that in your (silabs') vendor driver. > BTW, can you suggest (preferably automated) serial port test s/w? No, sorry. I have a bunch of test code that I intend to organise and clean up at some point, but I never seem to find the time to actually do it. Johan