From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbbJaQj2 (ORCPT ); Sat, 31 Oct 2015 12:39:28 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35673 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbbJaQjY (ORCPT ); Sat, 31 Oct 2015 12:39:24 -0400 Date: Sat, 31 Oct 2015 17:39:19 +0100 From: Bogicevic Sasa To: Joe Perches Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Message-ID: <20151031163919.GB3550@gmail.com> References: <1446300051-12151-1-git-send-email-brutallesale@gmail.com> <1446307028.2757.210.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1446307028.2757.210.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31, Joe Perches wrote: >On Sat, 2015-10-31 at 15:00 +0100, Bogicevic Sasa wrote: >> This fixes line over 80 characters message from checkpatch.pl >[] >> diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c >[] >> @@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) >> >> spin_lock_irqsave(&qcb->qos_lock, flags); >> qcb->csr[index].sfid = sfid; >> - qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00); >> + qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & >> + 0xff00); > >Probably better to remove the unnecessary parentheses instead > > qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00; > > > You're right, I just sent a new patch. Thanks, Sasa