From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752772AbbKASLD (ORCPT <rfc822;w@1wt.eu>);
	Sun, 1 Nov 2015 13:11:03 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:53943 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751999AbbKASLA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 1 Nov 2015 13:11:00 -0500
Date: Sun, 1 Nov 2015 10:10:59 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Ranjith <ranjithece24@gmail.com>, devel@driverdev.osuosl.org,
        Ian Abbott <abbotti@mev.co.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue
Message-ID: <20151101181059.GA14252@kroah.com>
References: <1446371994-12497-1-git-send-email-ranjithece24@gmail.com>
 <CAHp75VdTwiFF1wjb+Bw446kv08+5oLnYj_6T85jT2YD8wE+0rg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75VdTwiFF1wjb+Bw446kv08+5oLnYj_6T85jT2YD8wE+0rg@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 1, 2015 at 11:59 AM, Ranjith <ranjithece24@gmail.com> wrote:
> > BIT macro is used for defining bit location instead of shifting
> > operator -  coding style issue
> 
> >  #define APCI1032_CTRL_INT_OR           (0 << 1)
> 
> > +#define APCI1032_CTRL_INT_AND          BIT(1)
> 
> And now you have two styles at the same time. I wouldn't change the
> current definitions.

Yes you should, just use BIT(0) for this one.