From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752865AbbKASLj (ORCPT ); Sun, 1 Nov 2015 13:11:39 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53951 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbbKASLg (ORCPT ); Sun, 1 Nov 2015 13:11:36 -0500 Date: Sun, 1 Nov 2015 10:11:35 -0800 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Ranjith , devel@driverdev.osuosl.org, Ian Abbott , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue Message-ID: <20151101181135.GB14252@kroah.com> References: <1446371994-12497-1-git-send-email-ranjithece24@gmail.com> <20151101181059.GA14252@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151101181059.GA14252@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 01, 2015 at 10:10:59AM -0800, Greg Kroah-Hartman wrote: > On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote: > > On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote: > > > BIT macro is used for defining bit location instead of shifting > > > operator - coding style issue > > > > > #define APCI1032_CTRL_INT_OR (0 << 1) > > > > > +#define APCI1032_CTRL_INT_AND BIT(1) > > > > And now you have two styles at the same time. I wouldn't change the > > current definitions. > > Yes you should, just use BIT(0) for this one. Oh wait, nevermind, just use the "real" value instead, but using the BIT() macro is the correct thing, don't tell people not to use it.