Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

Greg Kroah-Hartman
2015-11-01T18:11:03Z

On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 1, 2015 at 11:59 AM, Ranjith <ranjithece24@gmail.com> wrote:
> > BIT macro is used for defining bit location instead of shifting
> > operator - coding style issue
>
> > #define APCI1032_CTRL_INT_OR (0 << 1)
>
> > +#define APCI1032_CTRL_INT_AND BIT(1)
>
> And now you have two styles at the same time. I wouldn't change the
> current definitions.

Yes you should, just use BIT(0) for this one.