public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Documentation: update of USB_CHIPIDEA_DEBUG
@ 2015-11-02  9:15 Valentin Rothberg
  2015-11-03  7:03 ` Peter Chen
  0 siblings, 1 reply; 2+ messages in thread
From: Valentin Rothberg @ 2015-11-02  9:15 UTC (permalink / raw)
  To: peter.chen; +Cc: gregkh, linux-kernel, Andreas Ziegler

Hi Peter,

your commit 2fb2884ed856 ("usb: chipidea: delete static debug support")
has shown up in today's Linux next tree (i.e., next-20151102) and
removes the Kconfig option USB_CHIPIDEA_DEBUG in favor of dynamic debug
support.  However, there are some documentary references on this option
still left in the code that may need to be updated:

Documentation/usb/chipidea.txt-9-If you want to check some internal variables for otg fsm,
Documentation/usb/chipidea.txt:10:select CONFIG_USB_CHIPIDEA_DEBUG, there are 2 files which
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^
Documentation/usb/chipidea.txt-11-can show otg fsm variables and some controller registers value:
--
drivers/usb/chipidea/core.c-25- * Compile Options
drivers/usb/chipidea/core.c:26: * - CONFIG_USB_CHIPIDEA_DEBUG: enable debug facilities
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^
drivers/usb/chipidea/core.c-27- * - STALL_IN:  non-empty bulk-in pipes cannot be halted


I'm just pointing to those references, since I don't know if you want to
keep them in the code or not.  I found the issue and your commit with
scipts/checkkconfigsymbols.py.

Kind regards,
 Valentin

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Documentation: update of USB_CHIPIDEA_DEBUG
  2015-11-02  9:15 Documentation: update of USB_CHIPIDEA_DEBUG Valentin Rothberg
@ 2015-11-03  7:03 ` Peter Chen
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2015-11-03  7:03 UTC (permalink / raw)
  To: Valentin Rothberg
  Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	Andreas Ziegler

On Mon, Nov 02, 2015 at 05:15:08PM +0800, Valentin Rothberg wrote:
> Hi Peter,
> 
> your commit 2fb2884ed856 ("usb: chipidea: delete static debug support")
> has shown up in today's Linux next tree (i.e., next-20151102) and
> removes the Kconfig option USB_CHIPIDEA_DEBUG in favor of dynamic debug
> support.  However, there are some documentary references on this option
> still left in the code that may need to be updated:
> 
> Documentation/usb/chipidea.txt-9-If you want to check some internal variables for otg fsm,
> Documentation/usb/chipidea.txt:10:select CONFIG_USB_CHIPIDEA_DEBUG, there are 2 files which
>                                          ^^^^^^^^^^^^^^^^^^^^^^^^^
> Documentation/usb/chipidea.txt-11-can show otg fsm variables and some controller registers value:
> --
> drivers/usb/chipidea/core.c-25- * Compile Options
> drivers/usb/chipidea/core.c:26: * - CONFIG_USB_CHIPIDEA_DEBUG: enable debug facilities
>                                     ^^^^^^^^^^^^^^^^^^^^^^^^^
> drivers/usb/chipidea/core.c-27- * - STALL_IN:  non-empty bulk-in pipes cannot be halted
> 
> 
> I'm just pointing to those references, since I don't know if you want to
> keep them in the code or not.  I found the issue and your commit with
> scipts/checkkconfigsymbols.py.

Thanks, Valentin. I will change them.

> 
> Kind regards,
>  Valentin

-- 

Best Regards,
Peter Chen

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-03  7:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-02  9:15 Documentation: update of USB_CHIPIDEA_DEBUG Valentin Rothberg
2015-11-03  7:03 ` Peter Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox