From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753884AbbKBPFQ (ORCPT ); Mon, 2 Nov 2015 10:05:16 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:35225 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbbKBPFJ (ORCPT ); Mon, 2 Nov 2015 10:05:09 -0500 Date: Mon, 2 Nov 2015 16:05:08 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Guenter Roeck , Neil Armstrong Subject: Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: lookup switch name Message-ID: <20151102150508.GD7963@lunn.ch> References: <1446248388-21060-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446248388-21060-1-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2015 at 07:39:48PM -0400, Vivien Didelot wrote: > All the mv88e6xxx drivers use the exact same code in their probe > function to lookup the switch name given its ID. Thus introduce a > mv88e6xxx_switch_id structure and a mv88e6xxx_lookup_name function in > the common mv88e6xxx code. > > In the meantime make __mv88e6xxx_reg_{read,write} static since we do not > need to expose these low-level r/w routines anymore. Acked-by: Andrew Lunn Thanks Andrew