From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754038AbbKBPnh (ORCPT ); Mon, 2 Nov 2015 10:43:37 -0500 Received: from mga11.intel.com ([192.55.52.93]:50602 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753411AbbKBPne (ORCPT ); Mon, 2 Nov 2015 10:43:34 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="825000709" Date: Mon, 2 Nov 2015 21:16:59 +0530 From: Vinod Koul To: Thomas Petazzoni Cc: Han Xu , fabio.estevam@freescale.com, boris.brezillon@free-electrons.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org, hofrat@osadl.org, shijie.huang@arm.com, dan.j.williams@intel.com, computersforpeace@gmail.com, dwmw2@infradead.org Subject: Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode' Message-ID: <20151102154659.GR21326@localhost> References: <1445983540-27155-1-git-send-email-b45815@freescale.com> <1445983540-27155-3-git-send-email-b45815@freescale.com> <20151031014244.GF21326@localhost> <20151102162906.1e3c29da@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151102162906.1e3c29da@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 02, 2015 at 04:29:06PM +0100, Thomas Petazzoni wrote: > Vinod, > > On Sat, 31 Oct 2015 07:12:44 +0530, Vinod Koul wrote: > > On Tue, Oct 27, 2015 at 05:05:35PM -0500, Han Xu wrote: > > > > > > -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma) > > > +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma) > > > > This change seems unrelated to patch description, can you explain why? > > It seems related: mxs_dma_init() is now no longer called at > initialization time, but also when resuming, as visible... Right looks good then -- ~Vinod