Re: [PATCH v3 2/2] arm64: dts: mt8173: Add thermal zone node for mt8173.

dawei chien
2015-11-02T10:51:34Z

On Wed, 2015-10-28 at 21:09 +0530, Viresh Kumar wrote:
> On 22-10-15, 20:02, Dawei Chien wrote:
> > Add thermal zone node to mt8173.dtsi.
> >
> > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> > ---
> > This patch is base on
> > https://patchwork.kernel.org/patch/7249821/
> > https://patchwork.kernel.org/patch/7249861/
> > https://patchwork.kernel.org/patch/7249891/
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 90 ++++++++++++++++++++++++++++++
> > 1 file changed, 90 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 3b18f37..eaf12bf 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -16,6 +16,7 @@
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/power/mt8173-power.h>
> > #include <dt-bindings/reset-controller/mt8173-resets.h>
> > +#include <dt-bindings/thermal/mt8173.h>
> > #include "mt8173-pinfunc.h"
> >
> > / {
> > @@ -54,6 +55,18 @@
> > reg = <0x000>;
> > enable-method = "psci";
> > cpu-idle-states = <&CPU_SLEEP_0>;
> > + static-power-points = <
> > + 859000 43
> > + 908000 52
> > + 983000 86
> > + 1009000 123
> > + 1028000 138
> > + 1083000 172
> > + 1110900 180
> > + 1125000 192
>
> What's the unit of power here? Is this power accurate? Or just a
> number representing the power ?

The unit is mW. This power was measured by tools, but it may be not
accurate enough since this tool has a error range.

> > + >;
> > + dynamic-power-coefficient = <263>;
> > + #cooling-cells = <2>;
> > };
>
> @Rob: Looks like another good candidate for the OPP-v2 table? Power.
>