From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754443AbbKBS2m (ORCPT ); Mon, 2 Nov 2015 13:28:42 -0500 Received: from foss.arm.com ([217.140.101.70]:52158 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752669AbbKBS2k (ORCPT ); Mon, 2 Nov 2015 13:28:40 -0500 Date: Mon, 2 Nov 2015 18:28:37 +0000 From: Will Deacon To: Steven Rostedt Cc: libin , kbuild test robot , kbuild-all@01.org, catalin.marinas@arm.com, takahiro.akashi@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, guohanjun@huawei.com, dingtianhong@huawei.com, zhouchengming1@huawei.com Subject: Re: [PATCH] recordmcount: arm64: replace the ignored mcount call into nop Message-ID: <20151102182836.GM29657@arm.com> References: <1446019445-14421-1-git-send-email-huawei.libin@huawei.com> <201510292118.ZYBYzBGa%fengguang.wu@intel.com> <20151029150922.GE3440@arm.com> <5633077C.3050000@huawei.com> <20151102132608.59e16994@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151102132608.59e16994@gandalf.local.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 02, 2015 at 01:26:08PM -0500, Steven Rostedt wrote: > On Fri, 30 Oct 2015 14:00:28 +0800 > libin wrote: > > > It is a bug in nop_mcount: > > ... > > if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) { > > if (make_nop) { > > ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset); > > } > > ... > > > > shdr->sh_offset and welp->r_offset should handle endianness properly as _w(shdr->sh_offset)/ > > _w(relp->r_offset). I will post a patchset including this patch soon. > > > > Has this been fixed yet? http://lkml.kernel.org/r/1446193864-24593-1-git-send-email-huawei.libin@huawei.com I see you're playing "chase the patches" at the moment ;) Will