From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752562AbbKCAcv (ORCPT ); Mon, 2 Nov 2015 19:32:51 -0500 Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:29479 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbbKCAct (ORCPT ); Mon, 2 Nov 2015 19:32:49 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2C8BwBm/zdW/+rW03ZegzuBQqpJAQEBBosuhSWGCYYTAgIBAQKBNU0BAQEBAQGBC4Q2AQEEJxMcIxAIAxgJJQ8FJQMhE4gvwgUBAQEHAgEgGYYXhUWJQAWHRY5+jR2cQ2OEGCo0AYV9AQEB Date: Tue, 3 Nov 2015 11:32:34 +1100 From: Dave Chinner To: Dan Williams Cc: axboe@fb.com, jack@suse.cz, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, ross.zwisler@linux.intel.com, hch@lst.de Subject: Re: [PATCH v3 13/15] block, dax: make dax mappings opt-in by default Message-ID: <20151103003234.GM10656@dastard> References: <20151102042941.6610.27784.stgit@dwillia2-desk3.amr.corp.intel.com> <20151102043053.6610.43948.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151102043053.6610.43948.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 01, 2015 at 11:30:53PM -0500, Dan Williams wrote: > Now that we have the ability to dynamically enable DAX for a raw block > inode, make the behavior opt-in by default. DAX does not have feature > parity with pagecache backed mappings, so applications should knowingly > enable DAX semantics. > > Note, this is only for mappings returned to userspace. For the > synchronous usages of DAX, dax_do_io(), there is no semantic difference > with the bio submission path, so that path remains default enabled. > > Signed-off-by: Dan Williams > --- > block/ioctl.c | 3 +-- > fs/block_dev.c | 33 +++++++++++++++++++++++---------- > include/linux/fs.h | 8 ++++++++ > 3 files changed, 32 insertions(+), 12 deletions(-) > > diff --git a/block/ioctl.c b/block/ioctl.c > index 205d57612fbd..c4c3a09d9ca9 100644 > --- a/block/ioctl.c > +++ b/block/ioctl.c > @@ -298,13 +298,12 @@ static inline int is_unrecognized_ioctl(int ret) > #ifdef CONFIG_FS_DAX > static int blkdev_set_dax(struct block_device *bdev, int n) > { > - struct gendisk *disk = bdev->bd_disk; > int rc = 0; > > if (n) > n = S_DAX; > > - if (n && !disk->fops->direct_access) > + if (n && !blkdev_dax_capable(bdev)) > return -ENOTTY; > > mutex_lock(&bdev->bd_inode->i_mutex); > diff --git a/fs/block_dev.c b/fs/block_dev.c > index 13ce6d0ff7f6..ee34a31e6fa4 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -152,16 +152,37 @@ static struct inode *bdev_file_inode(struct file *file) > return file->f_mapping->host; > } > > +#ifdef CONFIG_FS_DAX > +bool blkdev_dax_capable(struct block_device *bdev) > +{ > + struct gendisk *disk = bdev->bd_disk; > + > + if (!disk->fops->direct_access) > + return false; > + > + /* > + * If the partition is not aligned on a page boundary, we can't > + * do dax I/O to it. > + */ > + if ((bdev->bd_part->start_sect % (PAGE_SIZE / 512)) > + || (bdev->bd_part->nr_sects % (PAGE_SIZE / 512))) > + return false; > + > + return true; Where do you check that S_DAX has been enabled on the block device now? Cheers, Dave. -- Dave Chinner david@fromorbit.com